[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-edu-devel
Subject: Re: Review Request 110954: Rewrite FindBoostPython.cmake for correctness and stability
From: "Vadim Zhukov" <persgray () gmail ! com>
Date: 2013-06-20 8:35:37
Message-ID: 20130620083537.9912.6872 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
> On June 12, 2013, 6:02 p.m., David Narváez wrote:
> > Can you comment on the minimum CMake version required to use \
> > find_package_handle_standard_args() and \
> > cmake_push_check_state()/cmake_pop_check_state()? IIUC, FindKDE4Internal sets the \
> > minimum required to 2.8.9 so we need to check if that is a problem.
find_package_handle_standard_args() introduced in CMake 2.8, \
cmake_push_check_state()/cmake_pop_check_state - in CMake 2.8.5. They are more and \
more used in other KDE modules already.
- Vadim
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/110954/#review34222
-----------------------------------------------------------
On June 11, 2013, 7:10 p.m., Vadim Zhukov wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/110954/
> -----------------------------------------------------------
>
> (Updated June 11, 2013, 7:10 p.m.)
>
>
> Review request for KDE Edu and David Narváez.
>
>
> Description
> -------
>
> 1. Return compile check (see BoostPython_TRY_COMPILE() macro), it's needed for some \
> cases. Say, default Python in system is Python 3.3, and it gets picked up. But \
> Boost 1.53 python library could not work with it and requires Python 2.x. Without \
> compile check you'll pick up uncompatible Python version.
> 2. find_package(PkgConfig) moved under corresponding if(...) and \
> if(PKG_CONFIG_FOUND) is checked after. While it's spread enough, there is no \
> guarantee you'll have pkg-config on that system. Also, PYTHON_VERSIONS moved closer \
> to the scope where it's used to improve readability.
> 3. Use standard CMake find_package_handle_standard_args() and \
> cmake_push_check_state()/cmake_pop_check_state() instead of rolling own equivalent \
> logic. The latter logic was ever wrong, making HAVE_BOOST_SHARED_PTR_HPP check \
> fail.
> 4. BoostPython_INCLUDE_DIRS and BoostPython_LIBRARIES are saved in cache, as other \
> CMake modules do. This unbreaks the situation when CMake detects that it should be \
> re-run (for example, some CMakeLists.txt file was modified), and runs through \
> modules again - in this case, if BoostPython_INCLUDE_DIRS and BoostPython_LIBRARIES \
> are not in cache, all tests will be run again, and probably fail now.
>
> This addresses bug 320807.
> http://bugs.kde.org/show_bug.cgi?id=320807
>
>
> Diffs
> -----
>
> cmake/modules/FindBoostPython.cmake d6c5a34
>
> Diff: http://git.reviewboard.kde.org/r/110954/diff/
>
>
> Testing
> -------
>
> OpenBSD-CURRENT, CMake 2.8.11, KDE 4.10.4, Boost 1.53, Python 3.3 and 2.7.
>
>
> Thanks,
>
> Vadim Zhukov
>
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/110954/">http://git.reviewboard.kde.org/r/110954/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On June 12th, 2013, 6:02 p.m. MSK, <b>David \
Narváez</b> wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px solid \
#d0d0d0; padding-left: 10px;"> <pre style="white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Can you comment on the minimum CMake version required to use \
find_package_handle_standard_args() and \
cmake_push_check_state()/cmake_pop_check_state()? IIUC, FindKDE4Internal sets the \
minimum required to 2.8.9 so we need to check if that is a problem.</pre> \
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">find_package_handle_standard_args() introduced in CMake 2.8, \
cmake_push_check_state()/cmake_pop_check_state - in CMake 2.8.5. They are more and \
more used in other KDE modules already.</pre> <br />
<p>- Vadim</p>
<br />
<p>On June 11th, 2013, 7:10 p.m. MSK, Vadim Zhukov wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for KDE Edu and David Narváez.</div>
<div>By Vadim Zhukov.</div>
<p style="color: grey;"><i>Updated June 11, 2013, 7:10 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">1. Return compile check (see BoostPython_TRY_COMPILE() macro), it's \
needed for some cases. Say, default Python in system is Python 3.3, and it gets \
picked up. But Boost 1.53 python library could not work with it and requires Python \
2.x. Without compile check you'll pick up uncompatible Python version.
2. find_package(PkgConfig) moved under corresponding if(...) and if(PKG_CONFIG_FOUND) \
is checked after. While it's spread enough, there is no guarantee you'll have \
pkg-config on that system. Also, PYTHON_VERSIONS moved closer to the scope where \
it's used to improve readability.
3. Use standard CMake find_package_handle_standard_args() and \
cmake_push_check_state()/cmake_pop_check_state() instead of rolling own equivalent \
logic. The latter logic was ever wrong, making HAVE_BOOST_SHARED_PTR_HPP check fail.
4. BoostPython_INCLUDE_DIRS and BoostPython_LIBRARIES are saved in cache, as other \
CMake modules do. This unbreaks the situation when CMake detects that it should be \
re-run (for example, some CMakeLists.txt file was modified), and runs through modules \
again - in this case, if BoostPython_INCLUDE_DIRS and BoostPython_LIBRARIES are not \
in cache, all tests will be run again, and probably fail now.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">OpenBSD-CURRENT, CMake 2.8.11, KDE 4.10.4, Boost 1.53, Python 3.3 and \
2.7.</pre> </td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=320807">320807</a>
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>cmake/modules/FindBoostPython.cmake <span style="color: \
grey">(d6c5a34)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/110954/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
kde-edu mailing list
kde-edu@mail.kde.org
https://mail.kde.org/mailman/listinfo/kde-edu
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic