[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-edu-devel
Subject: Re: Review Request 111121: analitza fails to compile armhf due to qreal (float) and gldouble (double
From: "Maximiliano Curia" <maxy () debian ! org>
Date: 2013-06-19 17:01:18
Message-ID: 20130619170118.1889.16314 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
> On June 19, 2013, 3:42 p.m., Aleix Pol Gonzalez wrote:
> >
The call to glMultMatrixd(m_rot.data());
could be replaced by:
glMultMatrix(m_rot);
I think it makes no difference, anyway.
- Maximiliano
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111121/#review34683
-----------------------------------------------------------
On June 19, 2013, 3:33 p.m., Maximiliano Curia wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/111121/
> -----------------------------------------------------------
>
> (Updated June 19, 2013, 3:33 p.m.)
>
>
> Review request for KDE Edu and Aleix Pol Gonzalez.
>
>
> Description
> -------
>
> .
>
>
> This addresses bug 321244.
> http://bugs.kde.org/show_bug.cgi?id=321244
>
>
> Diffs
> -----
>
> analitzaplot/plotter3d.cpp 492a84c87558ce85722b0d26727f264a6d914e4c
>
> Diff: http://git.reviewboard.kde.org/r/111121/diff/
>
>
> Testing
> -------
>
> .
>
>
> Thanks,
>
> Maximiliano Curia
>
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/111121/">http://git.reviewboard.kde.org/r/111121/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">The call to \
glMultMatrixd(m_rot.data()); could be replaced by:
glMultMatrix(m_rot);
I think it makes no difference, anyway.</pre>
<br />
<p>- Maximiliano</p>
<br />
<p>On June 19th, 2013, 3:33 p.m. UTC, Maximiliano Curia wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for KDE Edu and Aleix Pol Gonzalez.</div>
<div>By Maximiliano Curia.</div>
<p style="color: grey;"><i>Updated June 19, 2013, 3:33 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">.</pre> </td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=321244">321244</a>
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>analitzaplot/plotter3d.cpp <span style="color: \
grey">(492a84c87558ce85722b0d26727f264a6d914e4c)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/111121/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
kde-edu mailing list
kde-edu@mail.kde.org
https://mail.kde.org/mailman/listinfo/kde-edu
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic