[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-edu-devel
Subject: Re: Review Request: Polish data/pointer type editing dialogs a bit.
From: "Andreas Cord-Landwehr" <cola () uni-paderborn ! de>
Date: 2012-08-08 17:38:41
Message-ID: 20120808173841.27375.10959 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105921/#review17121
-----------------------------------------------------------
Some small comments
* the dialog is too small to show the full caption
* the next button for "Enter" when the focus is on the name line-edit shoul=
d not be "Delete" but "Close"
* the new data/pointer type should get a default name, e.g., "Data Type" or=
"Connection Type"
* "Add Pointer Type"/"Add Data Type" should be more separated to "Delete" s=
ince Delete has a semantic meaning for the currently selected type, contrar=
y to the add type action
- Andreas Cord-Landwehr
On Aug. 7, 2012, 9:34 p.m., Frederik Gladhorn wrote:
> =
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/105921/
> -----------------------------------------------------------
> =
> (Updated Aug. 7, 2012, 9:34 p.m.)
> =
> =
> Review request for KDE Edu, Andreas Cord-Landwehr and Tomaz Canabrava.
> =
> =
> Description
> -------
> =
> Simplify add data/pointer type dialogs.
> =
> When adding a new type just focus the name edit,
> instead of having a line edit just for pre-setting its name.
> =
> Remove QWidgets as layout elements (use layouts instead).
> =
> Set buddies in the ui files.
> =
> =
> Diffs
> -----
> =
> src/Interface/DataTypePage.cpp 050b4fb3582756e19db36fa47b670854ddfcf342 =
> src/Interface/DataTypePage.ui f0593163eca889ea7c34b64cd6ad034dd3d84e53 =
> src/Interface/PointerTypePage.cpp 245710adfa467aaff7b1dfa2e6f8502f7a3f2=
ce3 =
> src/Interface/PointerTypePage.ui 88a6ff1300fdc2719be6027fb3d1c39776625b=
dc =
> =
> Diff: http://git.reviewboard.kde.org/r/105921/diff/
> =
> =
> Testing
> -------
> =
> =
> Thanks,
> =
> Frederik Gladhorn
> =
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/105921/">http://git.reviewboard.kde.org/r/105921/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Some \
small comments
* the dialog is too small to show the full caption
* the next button for "Enter" when the focus is on the name line-edit \
should not be "Delete" but "Close"
* the new data/pointer type should get a default name, e.g., "Data Type" or \
"Connection Type"
* "Add Pointer Type"/"Add Data Type" should be more separated to \
"Delete" since Delete has a semantic meaning for the currently selected \
type, contrary to the add type action</pre> <br />
<p>- Andreas</p>
<br />
<p>On August 7th, 2012, 9:34 p.m., Frederik Gladhorn wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for KDE Edu, Andreas Cord-Landwehr and Tomaz Canabrava.</div>
<div>By Frederik Gladhorn.</div>
<p style="color: grey;"><i>Updated Aug. 7, 2012, 9:34 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Simplify add data/pointer type dialogs.
When adding a new type just focus the name edit,
instead of having a line edit just for pre-setting its name.
Remove QWidgets as layout elements (use layouts instead).
Set buddies in the ui files.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/Interface/DataTypePage.cpp <span style="color: \
grey">(050b4fb3582756e19db36fa47b670854ddfcf342)</span></li>
<li>src/Interface/DataTypePage.ui <span style="color: \
grey">(f0593163eca889ea7c34b64cd6ad034dd3d84e53)</span></li>
<li>src/Interface/PointerTypePage.cpp <span style="color: \
grey">(245710adfa467aaff7b1dfa2e6f8502f7a3f2ce3)</span></li>
<li>src/Interface/PointerTypePage.ui <span style="color: \
grey">(88a6ff1300fdc2719be6027fb3d1c39776625bdc)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/105921/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
kde-edu mailing list
kde-edu@mail.kde.org
https://mail.kde.org/mailman/listinfo/kde-edu
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic