'Re: Review Request: Move graph name line edit into the title instead of having the name twice.'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-edu-devel
Subject:    Re: Review Request: Move graph name line edit into the title instead of having the name twice.
From:       "Andreas Cord-Landwehr" <cola () uni-paderborn ! de>
Date:       2012-08-08 17:22:09
Message-ID: 20120808172209.26206.17194 () vidsolbach ! de
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105922/#review17120
-----------------------------------------------------------

Ship it!

Ship It!

- Andreas Cord-Landwehr

On Aug. 7, 2012, 11:08 p.m., Frederik Gladhorn wrote:
> =

> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/105922/
> -----------------------------------------------------------
> =

> (Updated Aug. 7, 2012, 11:08 p.m.)
> =

> =

> Review request for KDE Edu, Andreas Cord-Landwehr and Tomaz  Canabrava.
> =

> =

> Description
> -------
> =

> Graph names were in the radio button label and on the line below as line =
edit. Move the line edit up instead of the radio button label.
> =

> =

> Diffs
> -----
> =

>   src/Interface/DataStructurePropertiesWidget.h 5a4a61ccf53e0d8445472c26c=
9a7b710819ae234 =

>   src/Interface/DataStructurePropertiesWidget.cpp aa98c898ea1b0d78c3107ad=
3b1ce126aec3b65c8 =

>   src/Interface/DataStructurePropertiesWidget.ui d4b9a31b97ac5fc7d8d7a176=
8340878279c0e544 =

> =

> Diff: http://git.reviewboard.kde.org/r/105922/diff/
> =

> =

> Testing
> -------
> =

> =

> Thanks,
> =

> Frederik Gladhorn
> =

>

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://git.reviewboard.kde.org/r/105922/">http://git.reviewboard.kde.org/r/105922/</a>
  </td>
    </tr>
   </table>
   <br />

 <p>Ship it!</p>

 <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Ship It!</pre>  <br />

<p>- Andreas</p>

<br />
<p>On August 7th, 2012, 11:08 p.m., Frederik Gladhorn wrote:</p>

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for KDE Edu, Andreas Cord-Landwehr and Tomaz  Canabrava.</div>
<div>By Frederik Gladhorn.</div>

<p style="color: grey;"><i>Updated Aug. 7, 2012, 11:08 p.m.</i></p>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Graph names were in the radio button label and on the line below as line \
edit. Move the line edit up instead of the radio button label.</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>src/Interface/DataStructurePropertiesWidget.h <span style="color: \
grey">(5a4a61ccf53e0d8445472c26c9a7b710819ae234)</span></li>

 <li>src/Interface/DataStructurePropertiesWidget.cpp <span style="color: \
grey">(aa98c898ea1b0d78c3107ad3b1ce126aec3b65c8)</span></li>

 <li>src/Interface/DataStructurePropertiesWidget.ui <span style="color: \
grey">(d4b9a31b97ac5fc7d8d7a1768340878279c0e544)</span></li>

</ul>

<p><a href="http://git.reviewboard.kde.org/r/105922/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

_______________________________________________
kde-edu mailing list
kde-edu@mail.kde.org
https://mail.kde.org/mailman/listinfo/kde-edu

[prev in list] [next in list] [prev in thread] [next in thread] 