[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-edu-devel
Subject: Re: Review Request: Add conjunction to the (default) word types
From: "Jan Gerrit Marker" <jangerrit () weiler-marker ! com>
Date: 2011-11-28 21:44:23
Message-ID: 20111128214423.25774.10291 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
> On Nov. 23, 2011, 2:09 p.m., Frederik Gladhorn wrote:
> > Looks great. Please commit.
Sorry for the delay.
The commit would add a new string, is this allowed for Parley currently? I =
don't know whether it sticks to KDE's freezes.
- Jan Gerrit
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103192/#review8412
-----------------------------------------------------------
On Nov. 22, 2011, 4:41 p.m., Jan Gerrit Marker wrote:
> =
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/103192/
> -----------------------------------------------------------
> =
> (Updated Nov. 22, 2011, 4:41 p.m.)
> =
> =
> Review request for KDE Edu.
> =
> =
> Description
> -------
> =
> This patch does two things:
> * Adds conjunction to the list of special word types in the context menu =
of the word type view
> * Adds conjunction to the default list of word types when creating a new =
file
> =
> I would commit them separately, but the patches are that small that I did=
load them up together.
> =
> Update:
> In order to save and load the word type correctly the patch which is post=
ed at https://git.reviewboard.kde.org/r/103204/ is needed.
> =
> =
> Diffs
> -----
> =
> src/parleydocument.cpp 047b703 =
> src/vocabulary/wordtypeview.h 24b8a2c =
> src/vocabulary/wordtypeview.cpp 1d399b6 =
> =
> Diff: http://git.reviewboard.kde.org/r/103192/diff/diff
> =
> =
> Testing
> -------
> =
> Works for me.
> =
> =
> Thanks,
> =
> Jan Gerrit Marker
> =
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/103192/">http://git.reviewboard.kde.org/r/103192/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On November 23rd, 2011, 2:09 p.m., <b>Frederik \
Gladhorn</b> wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px solid \
#d0d0d0; padding-left: 10px;"> <pre style="white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Looks great. Please commit.</pre> </blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Sorry for the delay. The \
commit would add a new string, is this allowed for Parley currently? I don't know \
whether it sticks to KDE's freezes.</pre> <br />
<p>- Jan Gerrit</p>
<br />
<p>On November 22nd, 2011, 4:41 p.m., Jan Gerrit Marker wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for KDE Edu.</div>
<div>By Jan Gerrit Marker.</div>
<p style="color: grey;"><i>Updated Nov. 22, 2011, 4:41 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">This patch does two things:
* Adds conjunction to the list of special word types in the context menu of the word \
type view
* Adds conjunction to the default list of word types when creating a new file
I would commit them separately, but the patches are that small that I did load them \
up together.
Update:
In order to save and load the word type correctly the patch which is posted at \
https://git.reviewboard.kde.org/r/103204/ is needed.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Works for me.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/parleydocument.cpp <span style="color: grey">(047b703)</span></li>
<li>src/vocabulary/wordtypeview.h <span style="color: grey">(24b8a2c)</span></li>
<li>src/vocabulary/wordtypeview.cpp <span style="color: grey">(1d399b6)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/103192/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
kde-edu mailing list
kde-edu@mail.kde.org
https://mail.kde.org/mailman/listinfo/kde-edu
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic