[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-edu-devel
Subject: Re: Review Request: Add conjunction to the kvtml2reader and writer
From: "Commit Hook" <null () kde ! org>
Date: 2011-11-28 21:04:14
Message-ID: 20111128210414.23237.70636 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103204/#review8582
-----------------------------------------------------------
This review has been submitted with commit eb7e2688c30badeef537480e002cd289=
5cca887f by Jan Gerrit Marker to branch master.
- Commit Hook
On Nov. 22, 2011, 4:40 p.m., Jan Gerrit Marker wrote:
> =
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/103204/
> -----------------------------------------------------------
> =
> (Updated Nov. 22, 2011, 4:40 p.m.)
> =
> =
> Review request for KDE Edu.
> =
> =
> Description
> -------
> =
> This patch adds the word type "conjunction" to the reader and writer for =
KVTML2. It is needed to save the information which is added in the parley p=
atch I posted recently ( https://git.reviewboard.kde.org/r/103192/ ). I thi=
nk it is necessary to have this in the library because the conjunction type=
is also defined in the enumeration which holds the word types the library =
can handle.
> =
> =
> Diffs
> -----
> =
> keduvocdocument/keduvockvtml2reader.cpp 83cf9af =
> keduvocdocument/keduvockvtml2writer.cpp 9e26743 =
> keduvocdocument/kvtml2defs.h 18b79bb =
> =
> Diff: http://git.reviewboard.kde.org/r/103204/diff/diff
> =
> =
> Testing
> -------
> =
> It works using this test case:
> Create a new file in parley (the patch I mentioned above needs to be appl=
ied), add a conjunction and set the word type, save the file, restart parle=
y and load the file. The type of the conjunction you added is conjunction a=
nd the special type of the word type conjunction is conjunction, too.
> =
> =
> Thanks,
> =
> Jan Gerrit Marker
> =
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/103204/">http://git.reviewboard.kde.org/r/103204/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This review has been \
submitted with commit eb7e2688c30badeef537480e002cd2895cca887f by Jan Gerrit Marker \
to branch master.</pre> <br />
<p>- Commit</p>
<br />
<p>On November 22nd, 2011, 4:40 p.m., Jan Gerrit Marker wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for KDE Edu.</div>
<div>By Jan Gerrit Marker.</div>
<p style="color: grey;"><i>Updated Nov. 22, 2011, 4:40 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">This patch adds the word type "conjunction" to the reader and \
writer for KVTML2. It is needed to save the information which is added in the parley \
patch I posted recently ( https://git.reviewboard.kde.org/r/103192/ ). I think it is \
necessary to have this in the library because the conjunction type is also defined in \
the enumeration which holds the word types the library can handle.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">It works using this test case: Create a new file in parley (the patch I \
mentioned above needs to be applied), add a conjunction and set the word type, save \
the file, restart parley and load the file. The type of the conjunction you added is \
conjunction and the special type of the word type conjunction is conjunction, \
too.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>keduvocdocument/keduvockvtml2reader.cpp <span style="color: \
grey">(83cf9af)</span></li>
<li>keduvocdocument/keduvockvtml2writer.cpp <span style="color: \
grey">(9e26743)</span></li>
<li>keduvocdocument/kvtml2defs.h <span style="color: grey">(18b79bb)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/103204/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
kde-edu mailing list
kde-edu@mail.kde.org
https://mail.kde.org/mailman/listinfo/kde-edu
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic