[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-edu-devel
Subject: [kde-edu]: Re: Review Request: KTouch: Fix for "clear history" bug
From: Peter_Rüthemann <peter.ruethemann () gmail ! com>
Date: 2011-03-28 18:56:17
Message-ID: 20110328185617.1710.60584 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/6549/
-----------------------------------------------------------
(Updated March 28, 2011, 6:56 p.m.)
Review request for KDE-Edu.
Changes
-------
I needed the time to get deeper into Qt. I hope the fix works now also for you.
The problem was that I cleared the whole hash table.
Good evening
Peter
Summary
-------
In the current version it's not possible to clear the statistics in the "training \
statistics" window. Only a part of the statistics was cleared.
Changelog:
- The fix clears the current statistics and refreshes the UI
- The sessions restarts at the current level
- The clearStatistics function has now a parameter. The parameter decides whether a \
new session should be started or not.
This is my first bug fix. Let me know if I violated some coding rules.
Peter
This addresses bug 149758.
https://bugs.kde.org/show_bug.cgi?id=149758
Diffs (updated)
-----
/trunk/KDE/kdeedu/ktouch/src/ktouch.cpp 1226325
/trunk/KDE/kdeedu/ktouch/src/ktouchstatisticsdialog.cpp 1226325
/trunk/KDE/kdeedu/ktouch/src/ktouch.h 1226325
Diff: http://svn.reviewboard.kde.org/r/6549/diff
Testing
-------
Works with compiled KTouch.
Thanks,
Peter
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://svn.reviewboard.kde.org/r/6549/">http://svn.reviewboard.kde.org/r/6549/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://svn.reviewboard.kde.orgrb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for KDE-Edu.</div>
<div>By Peter Rüthemann.</div>
<p style="color: grey;"><i>Updated March 28, 2011, 6:56 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">I needed the time to get deeper into Qt. I hope the fix works now also \
for you. The problem was that I cleared the whole hash table.
Good evening
Peter</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">In the current version it's not possible to clear the statistics in \
the "training statistics" window. Only a part of the statistics was \
cleared.
Changelog:
- The fix clears the current statistics and refreshes the UI
- The sessions restarts at the current level
- The clearStatistics function has now a parameter. The parameter decides whether a \
new session should be started or not.
This is my first bug fix. Let me know if I violated some coding rules.
Peter
</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Works with compiled KTouch.</pre> </td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="https://bugs.kde.org/show_bug.cgi?id=149758">149758</a>
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> \
(updated)</h1> <ul style="margin-left: 3em; padding-left: 0;">
<li>/trunk/KDE/kdeedu/ktouch/src/ktouch.cpp <span style="color: \
grey">(1226325)</span></li>
<li>/trunk/KDE/kdeedu/ktouch/src/ktouchstatisticsdialog.cpp <span style="color: \
grey">(1226325)</span></li>
<li>/trunk/KDE/kdeedu/ktouch/src/ktouch.h <span style="color: \
grey">(1226325)</span></li>
</ul>
<p><a href="http://svn.reviewboard.kde.org/r/6549/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
kde-edu mailing list
kde-edu@mail.kde.org
https://mail.kde.org/mailman/listinfo/kde-edu
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic