'[kde-edu]: Review Request: KTouch: Fix for "clear history" bug'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-edu
Subject:    [kde-edu]:  Review Request: KTouch: Fix for "clear history" bug
From:       Peter_Rüthemann <peter.ruethemann () gmail ! com>
Date:       2011-04-10 20:49:38
Message-ID: 20110410204938.1886.64740 () vidsolbach ! de
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101078/
-----------------------------------------------------------

Review request for KDE Edu.

Summary
-------

Because ktouch finally moved to git, I publish my bug fix again.

I fixed a bug in KTouch. At the moment it's not possible to clear the statistics in \
the "training statistics" window. Only a part of the statistics was cleared. 

Changelog:
- The fix clears the current statistics and refreshes the UI
- The sessions restarts at the current level
- The clearStatistics function has now a parameter. The parameter decides whether a \
new session should be started or not.

I really like git and kdeedu, so I hope I can contribute a little bit.

Peter

This addresses bug 149758.
    http://bugs.kde.org/show_bug.cgi?id=149758

Diffs
-----

  src/ktouch.h 3744e72 
  src/ktouch.cpp 55bab64 
  src/ktouchstatisticsdialog.cpp 64faa43 

Diff: http://git.reviewboard.kde.org/r/101078/diff

Testing
-------

Fix works with compiled KTouch.

Thanks,

Peter

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://git.reviewboard.kde.org/r/101078/">http://git.reviewboard.kde.org/r/101078/</a>
  </td>
    </tr>
   </table>
   <br />

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for KDE Edu.</div>
<div>By Peter Rüthemann.</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Because ktouch finally moved to git, I publish my bug fix again.

I fixed a bug in KTouch. At the moment it&#39;s not possible to clear the statistics \
in the &quot;training statistics&quot; window. Only a part of the statistics was \
cleared. 

Changelog:
- The fix clears the current statistics and refreshes the UI
- The sessions restarts at the current level
- The clearStatistics function has now a parameter. The parameter decides whether a \
new session should be started or not.

I really like git and kdeedu, so I hope I can contribute a little bit.

Peter</pre>
  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Fix works with compiled KTouch.</pre>  </td>
 </tr>
</table>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>

 <a href="http://bugs.kde.org/show_bug.cgi?id=149758">149758</a>

</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>src/ktouch.h <span style="color: grey">(3744e72)</span></li>

 <li>src/ktouch.cpp <span style="color: grey">(55bab64)</span></li>

 <li>src/ktouchstatisticsdialog.cpp <span style="color: grey">(64faa43)</span></li>

</ul>

<p><a href="http://git.reviewboard.kde.org/r/101078/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

_______________________________________________
kde-edu mailing list
kde-edu@mail.kde.org
https://mail.kde.org/mailman/listinfo/kde-edu

[prev in list] [next in list] [prev in thread] [next in thread] 