[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-edu
Subject: Re: Review Request 112154: Make it possible to edit language settings in practice mode
From: "Inge Wallin" <inge () lysator ! liu ! se>
Date: 2013-08-19 13:46:48
Message-ID: 20130819134648.18283.8626 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112154/#review38137
-----------------------------------------------------------
src/editor/editor.cpp
<http://git.reviewboard.kde.org/r/112154/#comment28197>
Hmm, seems like an extra newline, yes. I'll check it.
- Inge Wallin
On Aug. 19, 2013, 11:11 a.m., Inge Wallin wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/112154/
> -----------------------------------------------------------
>
> (Updated Aug. 19, 2013, 11:11 a.m.)
>
>
> Review request for KDE Edu and Frederik Gladhorn.
>
>
> Description
> -------
>
> Currently Parley has a setting for editing language settings such as fontsize in \
> the editor and practice and also other, more language specific things. But this is \
> extremely well hidden in the editor mode only and under the Edit menu.
> This patch makes the language settings available also during practice.
>
> You could argue that settings for the language itself should be separated from \
> viewing settings but this is not the topic of this patch.
>
> Diffs
> -----
>
> src/editor/editor.cpp 6511a69
> src/practice/practicemainwindow.cpp 9f23ae9
> src/practice/practiceui.rc 96c4a06
>
> Diff: http://git.reviewboard.kde.org/r/112154/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Inge Wallin
>
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/112154/">http://git.reviewboard.kde.org/r/112154/</a>
</td>
</tr>
</table>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="http://git.reviewboard.kde.org/r/112154/diff/1/?file=183466#file183466line364" \
style="color: black; font-weight: bold; text-decoration: \
underline;">src/editor/editor.cpp</a> <span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">void \
EditorWindow::initActions()</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">364</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> \
<span class="n">SLOT</span><span class="p">(</span><span \
class="n">languageProperties</span><span class="p">()),</span> <span \
class="n">actionCollection</span><span class="p">());</span></pre></td> </tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Hmm, seems \
like an extra newline, yes. I'll check it.</pre> </div>
<br />
<p>- Inge</p>
<br />
<p>On August 19th, 2013, 11:11 a.m. UTC, Inge Wallin wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for KDE Edu and Frederik Gladhorn.</div>
<div>By Inge Wallin.</div>
<p style="color: grey;"><i>Updated Aug. 19, 2013, 11:11 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Currently Parley has a setting for editing language settings such as \
fontsize in the editor and practice and also other, more language specific things. \
But this is extremely well hidden in the editor mode only and under the Edit menu.
This patch makes the language settings available also during practice.
You could argue that settings for the language itself should be separated from \
viewing settings but this is not the topic of this patch.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/editor/editor.cpp <span style="color: grey">(6511a69)</span></li>
<li>src/practice/practicemainwindow.cpp <span style="color: \
grey">(9f23ae9)</span></li>
<li>src/practice/practiceui.rc <span style="color: grey">(96c4a06)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/112154/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
kde-edu mailing list
kde-edu@mail.kde.org
https://mail.kde.org/mailman/listinfo/kde-edu
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic