[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-doc-english
Subject: Re: [kde-doc-english] Review Request 115956: More generic (renamed) DocBookXML4.cmake, few fixes
From: "Alex Merry" <kde () randomguy3 ! me ! uk>
Date: 2014-02-23 15:03:16
Message-ID: 20140223150316.22874.14489 () probe ! kde ! org
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115956/#review50594
-----------------------------------------------------------
Ship it!
Ship It!
- Alex Merry
On Feb. 23, 2014, 3:02 p.m., Luigi Toscano wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/115956/
> -----------------------------------------------------------
>
> (Updated Feb. 23, 2014, 3:02 p.m.)
>
>
> Review request for Documentation and KDE Frameworks.
>
>
> Repository: kdoctools
>
>
> Description
> -------
>
> This is the combination of two RR, now that FindDocBookXML.cmake/FindDocBookXSL.cmake have \
> been moved to kdoctools:
> - https://git.reviewboard.kde.org/r/115876/
> - https://git.reviewboard.kde.org/r/115879/
>
> Combination of few commits:
> 1) More generic structure for FindDocBookXML
>
> - allows modules to request a generic version of DocBook XML
> - keep compatibility variables for now
> (originally from 115876)
> -------------------
> 2) Rename as FindDocBookXML4, it will be used only for DocBook 4.x
>
> The rename reflects the fact that it is used for DocBookXML4 only;
> a future DocBookXML5 could be added if needed.
> (originally from 115876)
>
> Use the new module name in CMake files.
> (originally from 115879)
> --------------------
> 3) New DocBookXML4_* variables, explicitly require the DocBookXML4 version
> (originally from 115879)
> --------------------
> 4) Move DocBookXML4 DESCRIPTION and URL into the cmake file
> --------------------
> 5) Move DocBookXSL DESCRIPTION and URL into the cmake file
>
>
> Diffs
> -----
>
> CMakeLists.txt 5ad7099
> cmake/FindDocBookXML.cmake b6d623e
> cmake/FindDocBookXML4.cmake PRE-CREATION
> cmake/FindDocBookXSL.cmake a7320ae
> config-kdoctools.h.cmake f2fe22c
> src/CMakeLists.txt 71a7d2e
> src/customization/dtd/kdex.dtd.cmake c643d9b
>
> Diff: https://git.reviewboard.kde.org/r/115956/diff/
>
>
> Testing
> -------
>
> Compiles, documentation is generated.
>
>
> Thanks,
>
> Luigi Toscano
>
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/115956/">https://git.reviewboard.kde.org/r/115956/</a>
</td>
</tr>
</table>
<br />
<p>Ship it!</p>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; \
white-space: -o-pre-wrap; word-wrap: break-word;">Ship It!</pre> <br />
<p>- Alex Merry</p>
<br />
<p>On February 23rd, 2014, 3:02 p.m. UTC, Luigi Toscano wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: \
url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black solid;"> <tr>
<td>
<div>Review request for Documentation and KDE Frameworks.</div>
<div>By Luigi Toscano.</div>
<p style="color: grey;"><i>Updated Feb. 23, 2014, 3:02 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kdoctools
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px \
solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This is the \
combination of two RR, now that FindDocBookXML.cmake/FindDocBookXSL.cmake have been moved to \
kdoctools:
- https://git.reviewboard.kde.org/r/115876/
- https://git.reviewboard.kde.org/r/115879/
Combination of few commits:
1) More generic structure for FindDocBookXML
- allows modules to request a generic version of DocBook XML
- keep compatibility variables for now
(originally from 115876)
-------------------
2) Rename as FindDocBookXML4, it will be used only for DocBook 4.x
The rename reflects the fact that it is used for DocBookXML4 only;
a future DocBookXML5 could be added if needed.
(originally from 115876)
Use the new module name in CMake files.
(originally from 115879)
--------------------
3) New DocBookXML4_* variables, explicitly require the DocBookXML4 version
(originally from 115879)
--------------------
4) Move DocBookXML4 DESCRIPTION and URL into the cmake file
--------------------
5) Move DocBookXSL DESCRIPTION and URL into the cmake file
</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid \
#b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Compiles, \
documentation is generated.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>CMakeLists.txt <span style="color: grey">(5ad7099)</span></li>
<li>cmake/FindDocBookXML.cmake <span style="color: grey">(b6d623e)</span></li>
<li>cmake/FindDocBookXML4.cmake <span style="color: grey">(PRE-CREATION)</span></li>
<li>cmake/FindDocBookXSL.cmake <span style="color: grey">(a7320ae)</span></li>
<li>config-kdoctools.h.cmake <span style="color: grey">(f2fe22c)</span></li>
<li>src/CMakeLists.txt <span style="color: grey">(71a7d2e)</span></li>
<li>src/customization/dtd/kdex.dtd.cmake <span style="color: grey">(c643d9b)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/115956/diff/" style="margin-left: 3em;">View \
Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
kde-doc-english mailing list
kde-doc-english@kde.org
https://mail.kde.org/mailman/listinfo/kde-doc-english
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic