From kde-doc-english Sun Feb 23 15:03:16 2014 From: "Alex Merry" Date: Sun, 23 Feb 2014 15:03:16 +0000 To: kde-doc-english Subject: Re: [kde-doc-english] Review Request 115956: More generic (renamed) DocBookXML4.cmake, few fixes Message-Id: <20140223150316.22874.14489 () probe ! kde ! org> X-MARC-Message: https://marc.info/?l=kde-doc-english&m=139316781229930 MIME-Version: 1 Content-Type: multipart/mixed; boundary="--===============5177772754203875321==" --===============5177772754203875321== Content-Type: multipart/alternative; boundary="===============1580444933116378635==" --===============1580444933116378635== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115956/#review50594 ----------------------------------------------------------- Ship it! Ship It! - Alex Merry On Feb. 23, 2014, 3:02 p.m., Luigi Toscano wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/115956/ > ----------------------------------------------------------- > > (Updated Feb. 23, 2014, 3:02 p.m.) > > > Review request for Documentation and KDE Frameworks. > > > Repository: kdoctools > > > Description > ------- > > This is the combination of two RR, now that FindDocBookXML.cmake/FindDocBookXSL.cmake have been moved to kdoctools: > - https://git.reviewboard.kde.org/r/115876/ > - https://git.reviewboard.kde.org/r/115879/ > > Combination of few commits: > 1) More generic structure for FindDocBookXML > > - allows modules to request a generic version of DocBook XML > - keep compatibility variables for now > (originally from 115876) > ------------------- > 2) Rename as FindDocBookXML4, it will be used only for DocBook 4.x > > The rename reflects the fact that it is used for DocBookXML4 only; > a future DocBookXML5 could be added if needed. > (originally from 115876) > > Use the new module name in CMake files. > (originally from 115879) > -------------------- > 3) New DocBookXML4_* variables, explicitly require the DocBookXML4 version > (originally from 115879) > -------------------- > 4) Move DocBookXML4 DESCRIPTION and URL into the cmake file > -------------------- > 5) Move DocBookXSL DESCRIPTION and URL into the cmake file > > > Diffs > ----- > > CMakeLists.txt 5ad7099 > cmake/FindDocBookXML.cmake b6d623e > cmake/FindDocBookXML4.cmake PRE-CREATION > cmake/FindDocBookXSL.cmake a7320ae > config-kdoctools.h.cmake f2fe22c > src/CMakeLists.txt 71a7d2e > src/customization/dtd/kdex.dtd.cmake c643d9b > > Diff: https://git.reviewboard.kde.org/r/115956/diff/ > > > Testing > ------- > > Compiles, documentation is generated. > > > Thanks, > > Luigi Toscano > > --===============1580444933116378635== Content-Type: text/html; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit
This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115956/

Ship it!

Ship It!

- Alex Merry


On February 23rd, 2014, 3:02 p.m. UTC, Luigi Toscano wrote:

Review request for Documentation and KDE Frameworks.
By Luigi Toscano.

Updated Feb. 23, 2014, 3:02 p.m.

Repository: kdoctools

Description 

This is the combination of two RR, now that FindDocBookXML.cmake/FindDocBookXSL.cmake have been moved to kdoctools:
- https://git.reviewboard.kde.org/r/115876/
- https://git.reviewboard.kde.org/r/115879/

Combination of few commits:
1) More generic structure for FindDocBookXML
    
- allows modules to request a generic version of DocBook XML
- keep compatibility variables for now
(originally from 115876)
-------------------
2) Rename as FindDocBookXML4, it will be used only for DocBook 4.x
    
The rename reflects the fact that it is used for DocBookXML4 only;
a future DocBookXML5 could be added if needed.
(originally from 115876)

Use the new module name in CMake files.
(originally from 115879)
--------------------
3) New DocBookXML4_* variables, explicitly require the DocBookXML4 version
(originally from 115879)
--------------------
4) Move DocBookXML4 DESCRIPTION and URL into the cmake file
--------------------
5) Move DocBookXSL DESCRIPTION and URL into the cmake file

Testing 

Compiles, documentation is generated.

Diffs

  • CMakeLists.txt (5ad7099)
  • cmake/FindDocBookXML.cmake (b6d623e)
  • cmake/FindDocBookXML4.cmake (PRE-CREATION)
  • cmake/FindDocBookXSL.cmake (a7320ae)
  • config-kdoctools.h.cmake (f2fe22c)
  • src/CMakeLists.txt (71a7d2e)
  • src/customization/dtd/kdex.dtd.cmake (c643d9b)

View Diff
--===============1580444933116378635==-- --===============5177772754203875321== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ kde-doc-english mailing list kde-doc-english@kde.org https://mail.kde.org/mailman/listinfo/kde-doc-english --===============5177772754203875321==--