[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-doc-english
Subject: Re: [kde-doc-english] Review Request 115744: Fix projects using KDocTools on windows.
From: "Alexander Richardson" <arichardson.kde () googlemail ! com>
Date: 2014-02-22 12:00:42
Message-ID: 20140222120042.7230.43006 () probe ! kde ! org
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115744/
-----------------------------------------------------------
(Updated Feb. 22, 2014, noon)
Status
------
This change has been marked as submitted.
Review request for Documentation, KDE Frameworks and Luigi Toscano.
Repository: kdoctools
Description
-------
Fix projects using KDocTools on windows.
If ${CMAKE_INSTALL_PREFIX}/${DATA_INSTALL_DIR} contained /../ elements
file(RELATIVE_PATH) would interpret these as valid directory names and
therefore return a relative path which has too many /../
REVIEW: 115744
Diffs
-----
src/CMakeLists.txt 241d56ffdb9f5cf4859eaf06aad491b9e1ca94fa
Diff: https://git.reviewboard.kde.org/r/115744/diff/
Testing
-------
kservice didn't compile before this change, now it does (win32), doesn't affect other platforms
Thanks,
Alexander Richardson
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/115744/">https://git.reviewboard.kde.org/r/115744/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#e0e0e0" width="100%" cellpadding="8" style="border: 1px gray solid;">
<tr>
<td>
<h1 style="margin-right: 0.2em; padding: 0; font-size: 10pt;">This change has been marked as \
submitted.</h1> </td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: \
url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black solid;"> <tr>
<td>
<div>Review request for Documentation, KDE Frameworks and Luigi Toscano.</div>
<div>By Alexander Richardson.</div>
<p style="color: grey;"><i>Updated Feb. 22, 2014, noon</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kdoctools
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px \
solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Fix projects using \
KDocTools on windows.
If ${CMAKE_INSTALL_PREFIX}/${DATA_INSTALL_DIR} contained /../ elements
file(RELATIVE_PATH) would interpret these as valid directory names and
therefore return a relative path which has too many /../
REVIEW: 115744</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid \
#b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">kservice didn't \
compile before this change, now it does (win32), doesn't affect other platforms</pre> \
</td> </tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/CMakeLists.txt <span style="color: \
grey">(241d56ffdb9f5cf4859eaf06aad491b9e1ca94fa)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/115744/diff/" style="margin-left: 3em;">View \
Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
kde-doc-english mailing list
kde-doc-english@kde.org
https://mail.kde.org/mailman/listinfo/kde-doc-english
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic