From kde-doc-english Sat Feb 22 12:00:42 2014 From: "Alexander Richardson" Date: Sat, 22 Feb 2014 12:00:42 +0000 To: kde-doc-english Subject: Re: [kde-doc-english] Review Request 115744: Fix projects using KDocTools on windows. Message-Id: <20140222120042.7230.43006 () probe ! kde ! org> X-MARC-Message: https://marc.info/?l=kde-doc-english&m=139307049912463 MIME-Version: 1 Content-Type: multipart/mixed; boundary="--===============1805421965498200370==" --===============1805421965498200370== Content-Type: multipart/alternative; boundary="===============4321267830911068064==" --===============4321267830911068064== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115744/ ----------------------------------------------------------- (Updated Feb. 22, 2014, noon) Status ------ This change has been marked as submitted. Review request for Documentation, KDE Frameworks and Luigi Toscano. Repository: kdoctools Description ------- Fix projects using KDocTools on windows. If ${CMAKE_INSTALL_PREFIX}/${DATA_INSTALL_DIR} contained /../ elements file(RELATIVE_PATH) would interpret these as valid directory names and therefore return a relative path which has too many /../ REVIEW: 115744 Diffs ----- src/CMakeLists.txt 241d56ffdb9f5cf4859eaf06aad491b9e1ca94fa Diff: https://git.reviewboard.kde.org/r/115744/diff/ Testing ------- kservice didn't compile before this change, now it does (win32), doesn't affect other platforms Thanks, Alexander Richardson --===============4321267830911068064== Content-Type: text/html; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit

This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115744/

This change has been marked as submitted.

Review request for Documentation, KDE Frameworks and Luigi Toscano.

By Alexander Richardson.

Updated Feb. 22, 2014, noon

Repository: kdoctools

Description

Fix projects using KDocTools on windows.

If ${CMAKE_INSTALL_PREFIX}/${DATA_INSTALL_DIR} contained /../ elements
file(RELATIVE_PATH) would interpret these as valid directory names and
therefore return a relative path which has too many /../

REVIEW: 115744

Testing

kservice didn't compile before this change, now it does (win32), doesn't affect other platforms

Diffs

src/CMakeLists.txt (241d56ffdb9f5cf4859eaf06aad491b9e1ca94fa)

View Diff

--===============4321267830911068064==-- --===============1805421965498200370== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ kde-doc-english mailing list kde-doc-english@kde.org https://mail.kde.org/mailman/listinfo/kde-doc-english --===============1805421965498200370==--