[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-devel
Subject:    [PATCH] kcmaudioslave: VBR min/max rate combos now working
From:       Pavel Troller <patrol () sinus ! cz>
Date:       2001-05-24 17:00:03
[Download RAW message or body]

Hi!
  I was puzzled why the comboboxes for specifying the minimal and maximal bitrates
for MP3 VBR were always disabled - and, what a surprise, didn't find any enabling code
for them.
  So I tried to implement this functionality. Please verify the following patch and
if it's OK, commit it, or at least be inspired and write a better one.

                                             With regards, Pavel Troller

["vbr.diff" (text/plain)]

? vbr.diff
Index: kcmaudiocd.cpp
===================================================================
RCS file: /home/kde/kdebase/kioslave/audiocd/kcmaudiocd/kcmaudiocd.cpp,v
retrieving revision 1.6
diff -u -3 -p -r1.6 kcmaudiocd.cpp
--- kcmaudiocd.cpp	2001/05/21 01:09:59	1.6
+++ kcmaudiocd.cpp	2001/05/24 16:11:28
@@ -143,10 +143,10 @@ KAudiocdModule::KAudiocdModule(QWidget *
     //MP3 VBR Groupbox
     connect(vbr_average_br,SIGNAL(clicked()),this,SLOT(slotUpdateVBRWidgets()));
     connect(vbr_min_hard,SIGNAL(clicked()),this,SLOT(slotConfigChanged()));
-    connect(vbr_min_br,SIGNAL(clicked()),this,SLOT(slotConfigChanged()));
+    connect(vbr_min_br,SIGNAL(clicked()),this,SLOT(slotUpdateVBRCombos()));
     connect(vbr_min_brate,SIGNAL(activated(int)),SLOT(slotConfigChanged()));
 
-    connect(vbr_max_br,SIGNAL(clicked()),this,SLOT(slotConfigChanged()));
+    connect(vbr_max_br,SIGNAL(clicked()),this,SLOT(slotUpdateVBRCombos()));
     connect(vbr_max_brate,SIGNAL(activated(int)),SLOT(slotConfigChanged()));
 
     connect(vbr_xing_tag,SIGNAL(clicked()),this,SLOT(slotConfigChanged()));
@@ -586,9 +586,22 @@ void KAudiocdModule::slotUpdateVBRWidget
     }
   }
 
-  slotConfigChanged();
+  slotUpdateVBRCombos();
 
   return;
+}
+
+//
+// slot for enabling and disabling VBR bitrate combo's
+//
+
+void KAudiocdModule::slotUpdateVBRCombos() {
+
+  vbr_min_brate->setEnabled((vbr_min_br->isEnabled())&&(vbr_min_br->isChecked())?true:false);
+  vbr_max_brate->setEnabled((vbr_max_br->isEnabled())&&(vbr_max_br->isChecked())?true:false);
+
+  slotConfigChanged();
+
 }
 
 QString KAudiocdModule::quickHelp() const
Index: kcmaudiocd.h
===================================================================
RCS file: /home/kde/kdebase/kioslave/audiocd/kcmaudiocd/kcmaudiocd.h,v
retrieving revision 1.4
diff -u -3 -p -r1.4 kcmaudiocd.h
--- kcmaudiocd.h	2001/05/19 11:16:08	1.4
+++ kcmaudiocd.h	2001/05/24 16:11:28
@@ -50,6 +50,7 @@ private slots:
 
  void slotSelectMethod(int);
  void slotUpdateVBRWidgets();
+ void slotUpdateVBRCombos();
  void slotConfigChanged();
  void slotChangeFilter();
  void slotEcDisable();

>> Visit http://master.kde.org/mailman/listinfo/kde-devel#unsub to unsubscribe <<


[prev in list] [next in list] [prev in thread] [next in thread]