[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-devel
Subject:    Re: KDE 2.2beta1
From:       David Faure <david () mandrakesoft ! com>
Date:       2001-03-29 11:18:36
[Download RAW message or body]

On Wednesday 28 March 2001 20:41, Sergio Moretti wrote:
> On Wednesday 28 March 2001 06:40, Waldo Bastian wrote:
> > Hiya,
> >
> > I especially would like to hear about the status of the following
> > issues:
> >
> > * new kio-slave configuration
> 
> oops, I was waiting for you, anyway, here the patch for kio directory, 
> plus two file for slave's manager. It compiles, but I haven't tested 
> it, it's more like a draft proposal. I have removed the call to 
> needConfiguration method in slavebase.cpp, as I think it's better to 
> insert it directly in slave code, maybe in constructor. What is left to 
> do is to map KProtocolManager methods to slaveManager, and to move some 
> slave code to new system. If you think that this is the right way, I 
> will try to convince the ftp slave to follow it, and I will make some 
> test.

I'll let Waldo comment on the "right way" issue - I got a bit lost in this discussion.
But a few minor things in this patch:
-        KProtocolManager::reparseConfiguration();
+        //KProtocolManager::reparseConfiguration(); to remove
No, leave it in ! That's very much needed, and completely unrelated.

There are a couple of conflicts in this patch.

// why there isn't a deleteEntry method in KConfig?
There is one, in KSimpleConfig. That is, a kconfig object
that points to a single file, whereas KConfig points to the
merging of global & local files (or more, depending on KDEDIRS).

In this particular case, KSimpleConfig can't be used, I guess
(we still want the possibility of "global" settings, i.e. in $KDEDIR).
What you could do instead: overwrite with a dummy entry.
For instance... writeEntry( key, "<unset>" ), and use that on reading
to dismiss the entry if the value is <unset>.

About naming: I'd rename localCfg to appCfg, because
global vs local means usually $KDEDIR vs ~/.kde.
In your case it's more like, kioslaverc vs myapprc.

Thanks for your work on this !

-- 
David FAURE, david@mandrakesoft.com, faure@kde.org
http://perso.mandrakesoft.com/~david/, http://www.konqueror.org/
KDE, Making The Future of Computing Available Today

 
>> Visit http://master.kde.org/mailman/listinfo/kde-devel#unsub to unsubscribe <<

[prev in list] [next in list] [prev in thread] [next in thread]