[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-devel
Subject:    Re: [Fwd: KFM memory leak: updated patch for khtmlw.]
From:       Lars Knoll <knoll () mpi-hd ! mpg ! de>
Date:       1999-08-31 10:32:36
[Download RAW message or body]

On Tue, 31 Aug 1999, Martin Jones wrote:
> 
> This patch works well for me too.
> Could a few more developers check it before it is committed.

Just checked it too. Ok, except for one small thing:

> @@ -1475,8 +1498,9 @@
>    _buffer.readBlock( buffer, 3 );
>    _buffer.close();
>      
> -  if ( strcmp( buffer, "GIF" ) == 0 )
> +  if ( strcmp( buffer, "GIF89a" ) == 0 )
>    {
> +    if (movie) delete movie;
>      movie = new QMovie( _buffer.buffer() );
>      movie->connectUpdate( this, SLOT( movieUpdated( const QRect &) ) );
>  #if QT_VERSION <= 141

This should rather be:

@@ -1469,14 +1492,15 @@
 {
   bComplete = true;
   
-  char buffer[ 4 ];
+  char buffer[ 7 ];
   buffer[0] = 0;
   _buffer.open( IO_ReadOnly );
-  _buffer.readBlock( buffer, 3 );
+  _buffer.readBlock( buffer, 6 );
   _buffer.close();
     
-  if ( strcmp( buffer, "GIF" ) == 0 )
+  if ( strcmp( buffer, "GIF89a" ) == 0 )
   {
+    if (movie) delete movie;
     movie = new QMovie( _buffer.buffer() );
     movie->connectUpdate( this, SLOT( movieUpdated( const QRect &) ) );
 #if QT_VERSION <= 141

Cheers,
Lars

[prev in list] [next in list] [prev in thread] [next in thread]