[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-devel
Subject:    1.1.2 thumbnail support
From:       "Stefan Siegel [Inf]" <siegel () rhrk ! uni-kl ! de>
Date:       1999-08-20 21:37:58
[Download RAW message or body]

Hi,

Please test this patch and commit it if, no problem occurs.

By building the "1.1.2pre_19990720" snapshots, i realized that kfm
still lacks png-thumbnail support. So I looked through source
code and realized, by adding a handfull lines we'll gain 
"image/x-bmp", "image/png", "image/tiff" and "image/x-xbm" support
(at least worked fine for me).

2nd file attached is the therefore needed 
         "$KDEDIR/share/mimelib/image/x-bmp.kdelink"
I hope it'll make it also in 1.1.2 release.

greetings

        Stefan

["thumbnail.patch" (text/plain)]

diff -uNr kdebase/kfm/kfmman.cpp kdebase.new/kfm/kfmman.cpp
--- kdebase/kfm/kfmman.cpp	Mon Jun  7 22:44:12 1999
+++ kdebase.new/kfm/kfmman.cpp	Fri Aug 20 22:33:00 1999
@@ -1821,10 +1821,12 @@
     
 	// At this time the icon protocol works for local files only.
 	KMimeType *mime = KMimeType::getMagicMimeType( _url );
-	if ( strcmp( mime->getMimeType(), "image/jpeg" ) == 0 ||
+	if ( strcmp( mime->getMimeType(), "image/x-bmp" ) == 0 ||
 	     strcmp( mime->getMimeType(), "image/gif" ) == 0 ||
-	     strcmp( mime->getMimeType(), "image/bmp" ) == 0 ||  
-                            // Added bmp, because it seems to work. David.
+	     strcmp( mime->getMimeType(), "image/jpeg" ) == 0 ||
+	     strcmp( mime->getMimeType(), "image/png" ) == 0 ||
+	     strcmp( mime->getMimeType(), "image/tiff" ) == 0 ||
+	     strcmp( mime->getMimeType(), "image/x-xbm" ) == 0 ||
 	     strcmp( mime->getMimeType(), "image/x-xpm" ) == 0 )
 	{
 	    QString result;

["x-bmp.kdelnk" (text/plain)]

# KDE Config File
[KDE Desktop Entry]
Type=MimeType
MimeType=image/x-bmp
Icon=image.xpm
Patterns=*.bmp;*.BMP;
Comment=bitmap image


[prev in list] [next in list] [prev in thread] [next in thread]