[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-devel
Subject:    Re: KConfigBase changes (isDesktopFile() and getConfigState())
From:       iglio () fub ! it (Pietro Iglio)
Date:       1999-07-14 14:59:52
[Download RAW message or body]

At 07.36 14/07/99 -0400, you wrote:
>Pietro Iglio <iglio@fub.it> wrote:
>> I would like to remove the code from kpanel to test whether a file
>> is a desktop file or not, and move everything in KConfigBase.
>> 
>> I propose to add a new method:
>> 
>>   static bool KConfig::isDesktopFile(QString path);
>> 
>> that returns true if the extension is either .kdelnk or .desktop
>
>Please make the test extension independent if possible.  I hope that's
>in the standard.
>
>(the .desktop extension doesn't seem to apply very well to KDE
>although it might be accurate for GNOME)

I think that it's important to have isDesktopFile() in the library. The
implementation can be changed in the future, and every application will
be automatically updated.

From my point of view, I don't see why we cannot rely on the extension:
do we need to open and parse a file to see if it is a desktop file?

-- Pietro

[prev in list] [next in list] [prev in thread] [next in thread]