[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-devel
Subject:    Re: kdeutils/kpm
From:       David Faure <faure () alpha ! tat ! physik ! uni-tuebingen ! de>
Date:       1999-05-25 21:24:39
[Download RAW message or body]

On Tue, May 25, 1999 at 11:11:15PM +0200, Stephan Kulow wrote:
> CVS by dfaure wrote:
> > 
> > kdeutils/kpm qps.C,1.8,1.9
> > Author: dfaure
> > CVSROOT: /home/kde
> > Tue May 25 22:57:01 MET DST 1999
> > Update of /home/kde/kdeutils/kpm
> > In directory zeus:/tmp/cvs-serv18328
> > 
> > Modified Files:
> >         qps.C
> > Log Message:
> > icon loading fixes.
> > What's the difference between loadApplicationIcon and ICON() ?
> 
> Good question as this is done often wrong.
> 
> ICON uses toolbar icons while loadApplicationIcon uses
> icons that application install for the K menu. That's
> a main difference that the old KIconloader used to mix ;(
It's a different meaning but it's the same way of finding the icon, isn't it ?

I'm really confused now.

QPixmap KIconLoader::loadApplicationIcon ( const QString& name, int w, int h )
{
        QPixmap result = loadIcon(locate("icon", name), w, h);
        return result;
} 

Doesn't that mean "no difference at all" ???

> BTW: I prefer Icon much more. Kalle once said ICON is the
> prefered way as this is an macro, but can't we make it a
> function? ;) 
> Icon is so much nicer to read in the code.
I don't agree. When I read ICON the first time, I knew it's a macro, 
and that's it's probably NOT defined in the source of the app, but in kdelibs
headers. Icon could be anything in the sources. Ok, we don't have
KAPP, LOCATE and so on, so forget this. Anyway we pollute too much the namespace
with all these duplicated methods. There are 10 ways to load an icon now !

-- 
David FAURE
david.faure@insa-lyon.fr, faure@kde.org
http://www.insa-lyon.fr/People/AEDI/dfaure/index.html 
KDE, Making The Future of Computing Available Today

[prev in list] [next in list] [prev in thread] [next in thread]