[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-devel
Subject:    Who merges Merge Requests, and when?
From:       Glen Ditchfield <GJDitchfield () acm ! org>
Date:       2020-06-10 16:19:36
Message-ID: 7118694.EvYhyI6sBW () copperplate
[Download RAW message or body]

In the Phabricator work flow, I would submit a patch, someone knowledgeable 
would accept it, and I would `arc land` it.  Clear and simple.

GitLab doesn't have that "accept" step AFAIK.  The KDE Wiki's Infrastructure/
GitLab page says "Once the Merge Request is accepted, KDE Developers will 
merge it for you!"  That is imprecise;  I'm in the Developer group, but I'm 
just a casual.

So, I have a couple of MRs in flight:

https://invent.kde.org/frameworks/kcalendarcore/-/merge_requests/1 hasn't 
attracted any review comments.  I don't think I _should_ merge it, but I think 
I _can_, which makes me uneasy.

https://invent.kde.org/pim/kcalutils/-/merge_requests/5 had comments, which I 
resolved.  So, do I merge it?  Do I wait for both reviewers to upvote it?  
Does a reviewer merge it?


[prev in list] [next in list] [prev in thread] [next in thread]