[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-devel
Subject: Re: Review Request 128554: Check for xattr during config step, otherwise the build might fail (if xa
From: Vishesh Handa <me () vhanda ! in>
Date: 2016-08-02 13:03:45
Message-ID: 20160802130345.20873.13437 () mimi ! kde ! org
[Download RAW message or body]
--===============5319217139274319449==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128554/#review97999
-----------------------------------------------------------
Ship it!
Ship It!
- Vishesh Handa
On July 29, 2016, 5:50 p.m., Johan Ouwerkerk wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128554/
> -----------------------------------------------------------
>
> (Updated July 29, 2016, 5:50 p.m.)
>
>
> Review request for Baloo.
>
>
> Repository: kfilemetadata
>
>
> Description
> -------
>
> Check for xattr during config step, otherwise the build might fail (if xattr.h is \
> missing). Missing xattr should now trigger an error message to prompt the user into \
> installing libattr + development packages.
> CMake logic is based on: \
> https://github.com/rpm-software-management/librepo/blob/master/cmake/Modules/FindXattr.cmake
> Taking some cues from an older KDE review request that Googling turned up: \
> https://git.reviewboard.kde.org/r/115877/
> Note: the rationale for this change is purely to 'document'/warn about the \
> previously hidden dependency on xattr when building from source. Currently this is \
> a hard dependency, compilation simply errors out if xattr headers aren't available. \
>
> Diffs
> -----
>
> CMakeLists.txt 4ec8eebe54fa8220c30930efffd8e76fd5eb0695
> cmake/FindXattr.cmake PRE-CREATION
>
> Diff: https://git.reviewboard.kde.org/r/128554/diff/
>
>
> Testing
> -------
>
> Without xattr development headers cmake now complains when building with \
> kdesrc-build. With xattr development headers installed, cmake & compilation steps \
> pass with kdesrc-build.
>
> Thanks,
>
> Johan Ouwerkerk
>
>
--===============5319217139274319449==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> \
<tr> <td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/128554/">https://git.reviewboard.kde.org/r/128554/</a>
</td>
</tr>
</table>
<br />
<p>
Ship it!
</p>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Ship It!</pre> <br />
<p>- Vishesh Handa</p>
<br />
<p>On July 29th, 2016, 5:50 p.m. UTC, Johan Ouwerkerk wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;"> <tr>
<td>
<div>Review request for Baloo.</div>
<div>By Johan Ouwerkerk.</div>
<p style="color: grey;"><i>Updated July 29, 2016, 5:50 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kfilemetadata
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Check for xattr during config step, otherwise the \
build might fail (if xattr.h is missing). Missing xattr should now trigger an error \
message to prompt the user into installing libattr + development packages.</p> <p \
style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">CMake logic is based on: \
https://github.com/rpm-software-management/librepo/blob/master/cmake/Modules/FindXattr.cmake
Taking some cues from an older KDE review request that Googling turned up: \
https://git.reviewboard.kde.org/r/115877/</p> <p style="padding: 0;text-rendering: \
inherit;margin: 0;line-height: inherit;white-space: inherit;">Note: the rationale for \
this change is purely to 'document'/warn about the previously hidden dependency on \
xattr when building from source. Currently this is a hard dependency, compilation \
simply errors out if xattr headers aren't available.</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Without xattr development headers cmake now complains \
when building with kdesrc-build. With xattr development headers installed, cmake \
& compilation steps pass with kdesrc-build.</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>CMakeLists.txt <span style="color: \
grey">(4ec8eebe54fa8220c30930efffd8e76fd5eb0695)</span></li>
<li>cmake/FindXattr.cmake <span style="color: grey">(PRE-CREATION)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/128554/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============5319217139274319449==--
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic