From kde-devel Tue Aug 02 13:03:45 2016 From: Vishesh Handa Date: Tue, 02 Aug 2016 13:03:45 +0000 To: kde-devel Subject: Re: Review Request 128554: Check for xattr during config step, otherwise the build might fail (if xa Message-Id: <20160802130345.20873.13437 () mimi ! kde ! org> X-MARC-Message: https://marc.info/?l=kde-devel&m=147014305722476 --===============5319217139274319449== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128554/#review97999 ----------------------------------------------------------- Ship it! Ship It! - Vishesh Handa On July 29, 2016, 5:50 p.m., Johan Ouwerkerk wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/128554/ > ----------------------------------------------------------- > > (Updated July 29, 2016, 5:50 p.m.) > > > Review request for Baloo. > > > Repository: kfilemetadata > > > Description > ------- > > Check for xattr during config step, otherwise the build might fail (if xattr.h is missing). Missing xattr should now trigger an error message to prompt the user into installing libattr + development packages. > > CMake logic is based on: https://github.com/rpm-software-management/librepo/blob/master/cmake/Modules/FindXattr.cmake > Taking some cues from an older KDE review request that Googling turned up: https://git.reviewboard.kde.org/r/115877/ > > Note: the rationale for this change is purely to 'document'/warn about the previously hidden dependency on xattr when building from source. Currently this is a hard dependency, compilation simply errors out if xattr headers aren't available. > > > Diffs > ----- > > CMakeLists.txt 4ec8eebe54fa8220c30930efffd8e76fd5eb0695 > cmake/FindXattr.cmake PRE-CREATION > > Diff: https://git.reviewboard.kde.org/r/128554/diff/ > > > Testing > ------- > > Without xattr development headers cmake now complains when building with kdesrc-build. > With xattr development headers installed, cmake & compilation steps pass with kdesrc-build. > > > Thanks, > > Johan Ouwerkerk > > --===============5319217139274319449== MIME-Version: 1.0 Content-Type: text/html; charset="utf-8" Content-Transfer-Encoding: 7bit

This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128554/

Ship it!

Ship It!

- Vishesh Handa

On July 29th, 2016, 5:50 p.m. UTC, Johan Ouwerkerk wrote:

Review request for Baloo.

By Johan Ouwerkerk.

Updated July 29, 2016, 5:50 p.m.

Repository: kfilemetadata

Description

Check for xattr during config step, otherwise the build might fail (if xattr.h is missing). Missing xattr should now trigger an error message to prompt the user into installing libattr + development packages.

CMake logic is based on: https://github.com/rpm-software-management/librepo/blob/master/cmake/Modules/FindXattr.cmake Taking some cues from an older KDE review request that Googling turned up: https://git.reviewboard.kde.org/r/115877/

Note: the rationale for this change is purely to 'document'/warn about the previously hidden dependency on xattr when building from source. Currently this is a hard dependency, compilation simply errors out if xattr headers aren't available.

Testing

Without xattr development headers cmake now complains when building with kdesrc-build. With xattr development headers installed, cmake & compilation steps pass with kdesrc-build.

Diffs

CMakeLists.txt (4ec8eebe54fa8220c30930efffd8e76fd5eb0695)
cmake/FindXattr.cmake (PRE-CREATION)

--===============5319217139274319449==--