[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-devel
Subject:    Re: Review Request 128189: DocumentUrlDB::del Only assert when children of dir actually exist
From:       Pinak Ahuja <pinak.ahuja () gmail ! com>
Date:       2016-06-16 17:50:45
Message-ID: 20160616175045.9803.36365 () mimi ! kde ! org
[Download RAW message or body]

--===============6652167120703028467==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128189/
-----------------------------------------------------------

(Updated June 16, 2016, 5:50 p.m.)


Status
------

This change has been marked as submitted.


Review request for Baloo.


Changes
-------

Submitted with commit 1274870e43b879e24c2f76f69544868a021513d3 by Pinak Ahuja to \
branch master.


Repository: baloo


Description
-------

We can have cases when deleting a directory from DocumentUrlDB when we have some \
children stored under it which actually don't exist on the file system. This can \
happen when the dir is being removed from DB because it doesn't exist on the \
filesystem.

We do need to work on cleaning up the DB when we encounter such behaviour or even \
better figure out why it is happening and preventing it from happening.


Diffs
-----

  src/engine/documenturldb.h 9bd5bb5 

Diff: https://git.reviewboard.kde.org/r/128189/diff/


Testing
-------

Fixed crash on CoLa's laptop.


Thanks,

Pinak Ahuja


--===============6652167120703028467==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit




<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">  \
<tr>  <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/128189/">https://git.reviewboard.kde.org/r/128189/</a>
  </td>
    </tr>
   </table>
   <br />



<table bgcolor="#e0e0e0" width="100%" cellpadding="12" style="border: 1px gray solid; \
border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">  <tr>
  <td>
   <h1 style="margin: 0; padding: 0; font-size: 10pt;">This change has been marked as \
submitted.</h1>  </td>
 </tr>
</table>
<br />


<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;">  <tr>
  <td>

<div>Review request for Baloo.</div>
<div>By Pinak Ahuja.</div>


<p style="color: grey;"><i>Updated June 16, 2016, 5:50 p.m.</i></p>



<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Submitted with commit 1274870e43b879e24c2f76f69544868a021513d3 by Pinak \
Ahuja to branch master.</pre>  </td>
 </tr>
</table>







<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
baloo
</div>


<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">We can have cases when deleting a directory from \
DocumentUrlDB when we have some children stored under it which actually don't exist \
on the file system. This can happen when the dir is being removed from DB because it \
doesn't exist on the filesystem.</p> <p style="padding: 0;text-rendering: \
inherit;margin: 0;line-height: inherit;white-space: inherit;">We do need to work on \
cleaning up the DB when we encounter such behaviour or even better figure out why it \
is happening and preventing it from happening.</p></pre>  </td>
 </tr>
</table>


<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Fixed crash on CoLa's laptop.</p></pre>  </td>
 </tr>
</table>


<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>src/engine/documenturldb.h <span style="color: grey">(9bd5bb5)</span></li>

</ul>

<p><a href="https://git.reviewboard.kde.org/r/128189/diff/" style="margin-left: \
3em;">View Diff</a></p>






  </td>
 </tr>
</table>



  </div>
 </body>
</html>


--===============6652167120703028467==--


[prev in list] [next in list] [prev in thread] [next in thread]

Configure | About | News | Add a list | Sponsored by KoreLogic