[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-devel
Subject: Re: Review Request 128189: DocumentUrlDB::del Only assert when children of dir actually exist
From: "R.Harish Navnit" <harishnavnit () gmail ! com>
Date: 2016-06-16 9:18:19
Message-ID: 20160616091819.9803.67022 () mimi ! kde ! org
[Download RAW message or body]
--===============4573856549434032012==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128189/#review96571
-----------------------------------------------------------
src/engine/documenturldb.h (line 145)
<https://git.reviewboard.kde.org/r/128189/#comment65237>
s/currupted/corrupted
- R.Harish Navnit
On June 15, 2016, 2:02 a.m., Pinak Ahuja wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128189/
> -----------------------------------------------------------
>
> (Updated June 15, 2016, 2:02 a.m.)
>
>
> Review request for Baloo.
>
>
> Repository: baloo
>
>
> Description
> -------
>
> We can have cases when deleting a directory from DocumentUrlDB when we have some \
> children stored under it which actually don't exist on the file system. This can \
> happen when the dir is being removed from DB because it doesn't exist on the \
> filesystem.
> We do need to work on cleaning up the DB when we encounter such behaviour or even \
> better figure out why it is happening and preventing it from happening.
>
> Diffs
> -----
>
> src/engine/documenturldb.h 9bd5bb5
>
> Diff: https://git.reviewboard.kde.org/r/128189/diff/
>
>
> Testing
> -------
>
> Fixed crash on CoLa's laptop.
>
>
> Thanks,
>
> Pinak Ahuja
>
>
--===============4573856549434032012==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> \
<tr> <td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/128189/">https://git.reviewboard.kde.org/r/128189/</a>
</td>
</tr>
</table>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="https://git.reviewboard.kde.org/r/128189/diff/1/?file=468781#file468781line145" \
style="color: black; font-weight: bold; text-decoration: \
underline;">src/engine/documenturldb.h</a> <span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">145</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> \
<span class="n">qWarning</span><span class="p">()</span> <span \
class="o"><<</span> <span class="s">"Database has currupted entries baloo \
may misbehave, please recreate the DB by running $ balooctl disable && \
balooctl enable"</span><span class="p">;</span></pre></td> </tr>
</tbody>
</table>
<div style="margin-left: 2em;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">s/currupted/corrupted</p></pre> </div>
</div>
<br />
<p>- R.Harish Navnit</p>
<br />
<p>On June 15th, 2016, 2:02 a.m. IST, Pinak Ahuja wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;"> <tr>
<td>
<div>Review request for Baloo.</div>
<div>By Pinak Ahuja.</div>
<p style="color: grey;"><i>Updated June 15, 2016, 2:02 a.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
baloo
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">We can have cases when deleting a directory from \
DocumentUrlDB when we have some children stored under it which actually don't exist \
on the file system. This can happen when the dir is being removed from DB because it \
doesn't exist on the filesystem.</p> <p style="padding: 0;text-rendering: \
inherit;margin: 0;line-height: inherit;white-space: inherit;">We do need to work on \
cleaning up the DB when we encounter such behaviour or even better figure out why it \
is happening and preventing it from happening.</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Fixed crash on CoLa's laptop.</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/engine/documenturldb.h <span style="color: grey">(9bd5bb5)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/128189/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============4573856549434032012==--
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic