'Re: Review Request 127728: Headers generated BalooDBusInterfaces custom'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-windows
Subject:    Re: Review Request 127728: Headers generated BalooDBusInterfaces custom
From:       Vishesh Handa <me () vhanda ! in>
Date:       2016-05-27 9:12:46
Message-ID: 20160527091246.6029.98757 () mimi ! kde ! org
[Download RAW message or body]

--===============7425247562622837675==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127728/#review95908
-----------------------------------------------------------

Ship it!

Ship It!

- Vishesh Handa

On April 23, 2016, 4:44 p.m., Andrius da Costa Ribas wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127728/
> -----------------------------------------------------------
> 
> (Updated April 23, 2016, 4:44 p.m.)
> 
> 
> Review request for Baloo and kdewin.
> 
> 
> Repository: baloo
> 
> 
> Description
> -------
> 
> Build targets under dbus subdirectory regardless of BUILD_KINOTIFY flag.
> 
> 
> Diffs
> -----
> 
> src/CMakeLists.txt 529b786 
> 
> Diff: https://git.reviewboard.kde.org/r/127728/diff/
> 
> 
> Testing
> -------
> 
> Fixes compiling problem on MSVC 2015 (missing generated "maininterface.h" for \
> "lib/indexerconfig.cpp"). No further testing done. 
> 
> Thanks,
> 
> Andrius da Costa Ribas
> 
> 

--===============7425247562622837675==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">  \
<tr>  <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/127728/">https://git.reviewboard.kde.org/r/127728/</a>
  </td>
    </tr>
   </table>
   <br />

<p>

Ship it!

</p>

 <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Ship It!</pre>  <br />

<p>- Vishesh Handa</p>

<br />
<p>On April 23rd, 2016, 4:44 p.m. UTC, Andrius da Costa Ribas wrote:</p>

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;">  <tr>
  <td>

<div>Review request for Baloo and kdewin.</div>
<div>By Andrius da Costa Ribas.</div>

<p style="color: grey;"><i>Updated April 23, 2016, 4:44 p.m.</i></p>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
baloo
</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Build targets under dbus subdirectory regardless of \
BUILD_KINOTIFY flag.</p></pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Fixes compiling problem on MSVC 2015 (missing \
generated "maininterface.h" for "lib/indexerconfig.cpp"). No further testing \
done.</p></pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>src/CMakeLists.txt <span style="color: grey">(529b786)</span></li>

</ul>

<p><a href="https://git.reviewboard.kde.org/r/127728/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

--===============7425247562622837675==--

[Attachment #3 (text/plain)]

_______________________________________________
Kde-windows mailing list
Kde-windows@kde.org
https://mail.kde.org/mailman/listinfo/kde-windows

[prev in list] [next in list] [prev in thread] [next in thread] 