From kde-windows Fri May 27 09:12:46 2016 From: Vishesh Handa Date: Fri, 27 May 2016 09:12:46 +0000 To: kde-windows Subject: Re: Review Request 127728: Headers generated BalooDBusInterfaces custom Message-Id: <20160527091246.6029.98757 () mimi ! kde ! org> X-MARC-Message: https://marc.info/?l=kde-windows&m=146434045322626 MIME-Version: 1 Content-Type: multipart/mixed; boundary="--===============3664487475963426503==" --===============3664487475963426503== Content-Type: multipart/alternative; boundary="===============7425247562622837675==" --===============7425247562622837675== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127728/#review95908 ----------------------------------------------------------- Ship it! Ship It! - Vishesh Handa On April 23, 2016, 4:44 p.m., Andrius da Costa Ribas wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/127728/ > ----------------------------------------------------------- > > (Updated April 23, 2016, 4:44 p.m.) > > > Review request for Baloo and kdewin. > > > Repository: baloo > > > Description > ------- > > Build targets under dbus subdirectory regardless of BUILD_KINOTIFY flag. > > > Diffs > ----- > > src/CMakeLists.txt 529b786 > > Diff: https://git.reviewboard.kde.org/r/127728/diff/ > > > Testing > ------- > > Fixes compiling problem on MSVC 2015 (missing generated "maininterface.h" for "lib/indexerconfig.cpp"). No further testing done. > > > Thanks, > > Andrius da Costa Ribas > > --===============7425247562622837675== MIME-Version: 1.0 Content-Type: text/html; charset="utf-8" Content-Transfer-Encoding: 7bit

This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127728/

Ship it!

Ship It!

- Vishesh Handa

On April 23rd, 2016, 4:44 p.m. UTC, Andrius da Costa Ribas wrote:

Review request for Baloo and kdewin.

By Andrius da Costa Ribas.

Updated April 23, 2016, 4:44 p.m.

Repository: baloo

Description

Build targets under dbus subdirectory regardless of BUILD_KINOTIFY flag.

Testing

Fixes compiling problem on MSVC 2015 (missing generated "maininterface.h" for "lib/indexerconfig.cpp"). No further testing done.

Diffs

src/CMakeLists.txt (529b786)

View Diff

--===============7425247562622837675==-- --===============3664487475963426503== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KS2RlLXdpbmRv d3MgbWFpbGluZyBsaXN0CktkZS13aW5kb3dzQGtkZS5vcmcKaHR0cHM6Ly9tYWlsLmtkZS5vcmcv bWFpbG1hbi9saXN0aW5mby9rZGUtd2luZG93cwo= --===============3664487475963426503==--