[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-devel
Subject: Re: I developed a workaround for Qt5.4 DND bug that KDE apps might need
From: PCMan <pcman.tw () gmail ! com>
Date: 2016-01-21 4:28:02
Message-ID: CAAMR6=4Majhfe6xqOoM0pjCFjC1XAJAFH1BEJ689cAEO_61hcw () mail ! gmail ! com
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
On Thu, Jan 21, 2016 at 6:16 AM, Frank Reininghaus <frank78ac@googlemail.com
> wrote:
> Hi,
>
> 2016-01-16 14:35 GMT+01:00 PCMan:
> > On Sat, Jan 16, 2016 at 6:20 PM, Kevin Krammer wrote:
> >>
> >> Hi,
> >>
> >> On Saturday, 2016-01-16, 12:43:53, PCMan wrote:
> >>
> >> > Since DND is crucial for a modern desktop environment and it's an
> >> > upstream
> >> > bug, I believe that KDE is also affected.
> >> > Luckily I found some quick workarounds, so I'm gonna share it with
> you.
> >> >
> >> > https://github.com/lxde/pcmanfm-qt/pull/295/files
> >> >
> >> > I made it an independent C++ class which is licensed under LGPL, so it
> >> > can
> >> > easily be reused by other Qt projects.
> >> > Just add two lines in your main() and it will work automagically.
> >> >
> >> > The bug still exists in Qt 5.5 and it's not yet fixed in Qt upstream.
> >>
> >> Sorry, this may be a stupid question: is this a proper fix or more like
> a
> >> hack?
> >
> > It's a quick hack rather than a proper fix.
> > The pusepose of this hack is simple.
> > Make it work for the window period before the users get the latest Qt
> which
> > contain a proper fix.
> >
> >>
> >> If the former, has it been submitted upstream?
> >
> > There's a patch in the Qt bug tracker, but nobody tests it.
> > The bug is left there for quite some time.
> > Even if it's fixed, for distributions like Debian, it takes ages for the
> > users to get the update.
> > So it's good to have some workaround. :-)
>
> First of all, thanks for sharing the workaround! I'm not familiar with
> the X11 drag&drop stuff, so I cannot comment on it.
>
> You said that a patch is in the Qt bug tracker, but all I could find
> with a bit of searching is a link to this Chromium report, which has a
> patch:
>
> https://code.google.com/p/chromium/issues/detail?id=543940
>
> Is that the patch you mean? Do you know if it has been submitted for
> review to Qt? If not, do you think that you could make that happen
> (since you seem to know quite a bit about drag&drop) or help to make
> it happen?
>
Yes, that's the patch I referred to.
It's not attached to the original bug report, but the patch is mentioned in
the comments.
FYI: https://bugreports.qt.io/browse/QTBUG-47981
I know part of the XDND protocol, but I do not fully understand what that
patch tries to do and how it works.
It's a good idea to test that patch if I have more time later though.
Thank you.
>
> Thanks,
> Frank
>
> >> Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to
> unsubscribe <<
>
[Attachment #5 (text/html)]
<div dir="ltr"><div class="gmail_extra"><div class="gmail_quote">On Thu, Jan 21, 2016 \
at 6:16 AM, Frank Reininghaus <span dir="ltr"><<a \
href="mailto:frank78ac@googlemail.com" \
target="_blank">frank78ac@googlemail.com</a>></span> wrote:<br><blockquote \
class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid \
rgb(204,204,204);padding-left:1ex">Hi,<br> <br>
2016-01-16 14:35 GMT+01:00 PCMan:<br>
<div><div class="h5">> On Sat, Jan 16, 2016 at 6:20 PM, Kevin Krammer wrote:<br>
>><br>
>> Hi,<br>
>><br>
>> On Saturday, 2016-01-16, 12:43:53, PCMan wrote:<br>
>><br>
>> > Since DND is crucial for a modern desktop environment and it's \
an<br> >> > upstream<br>
>> > bug, I believe that KDE is also affected.<br>
>> > Luckily I found some quick workarounds, so I'm gonna share it with \
you.<br> >> ><br>
>> > <a href="https://github.com/lxde/pcmanfm-qt/pull/295/files" \
rel="noreferrer" target="_blank">https://github.com/lxde/pcmanfm-qt/pull/295/files</a><br>
>> ><br>
>> > I made it an independent C++ class which is licensed under LGPL, so \
it<br> >> > can<br>
>> > easily be reused by other Qt projects.<br>
>> > Just add two lines in your main() and it will work automagically.<br>
>> ><br>
>> > The bug still exists in Qt 5.5 and it's not yet fixed in Qt \
upstream.<br> >><br>
>> Sorry, this may be a stupid question: is this a proper fix or more like \
a<br> >> hack?<br>
><br>
> It's a quick hack rather than a proper fix.<br>
> The pusepose of this hack is simple.<br>
> Make it work for the window period before the users get the latest Qt which<br>
> contain a proper fix.<br>
><br>
>><br>
>> If the former, has it been submitted upstream?<br>
><br>
> There's a patch in the Qt bug tracker, but nobody tests it.<br>
> The bug is left there for quite some time.<br>
> Even if it's fixed, for distributions like Debian, it takes ages for the<br>
> users to get the update.<br>
> So it's good to have some workaround. :-)<br>
<br>
</div></div>First of all, thanks for sharing the workaround! I'm not familiar \
with<br> the X11 drag&drop stuff, so I cannot comment on it.<br>
<br>
You said that a patch is in the Qt bug tracker, but all I could find<br>
with a bit of searching is a link to this Chromium report, which has a<br>
patch:<br>
<br>
<a href="https://code.google.com/p/chromium/issues/detail?id=543940" rel="noreferrer" \
target="_blank">https://code.google.com/p/chromium/issues/detail?id=543940</a><br> \
<br> Is that the patch you mean? Do you know if it has been submitted for<br>
review to Qt? If not, do you think that you could make that happen<br>
(since you seem to know quite a bit about drag&drop) or help to make<br>
it happen?<br></blockquote><div><br></div><div>Yes, that's the patch I referred \
to.<br></div><div>It's not attached to the original bug report, but the patch is \
mentioned in the comments.<br>FYI: <a \
href="https://bugreports.qt.io/browse/QTBUG-47981">https://bugreports.qt.io/browse/QTBUG-47981</a><br></div><div>I \
know part of the XDND protocol, but I do not fully understand what that patch tries \
to do and how it works.<br></div><div>It's a good idea to test that patch if I \
have more time later though.<br></div><div></div><div><br></div><div>Thank \
you.<br></div><div> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px \
0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"> <br>
Thanks,<br>
Frank<br>
<div class=""><div class="h5"><br>
>> Visit <a href="http://mail.kde.org/mailman/listinfo/kde-devel#unsub" \
rel="noreferrer" target="_blank">http://mail.kde.org/mailman/listinfo/kde-devel#unsub</a> \
to unsubscribe <<<br> </div></div></blockquote></div><br></div></div>
[Attachment #6 (text/plain)]
>> Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to unsubscribe <<
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic