'Re: Review Request 121266: fix build/test by making translation properties testable'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-devel
Subject:    Re: Review Request 121266: fix build/test by making translation properties testable
From:       "Harald Sitter" <sitter () kde ! org>
Date:       2014-12-18 13:37:16
Message-ID: 20141218133716.31947.21194 () probe ! kde ! org
[Download RAW message or body]

--===============0326373343729074536==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121266/
-----------------------------------------------------------

(Updated Dec. 18, 2014, 1:37 p.m.)

Status
------

This change has been marked as submitted.

Review request for Baloo and Vishesh Handa.

Repository: kfilemetadata

Description
-------

propertyinfotest iterates through all properties to make sure beginning
and end are set correctly and that all properties inbetween have a name
and description.

this was not the case for new translation properties, making the test fail

due to the nature of this test iterating through everything it would also
be very useful if the compiler warned about missing propertyinfos which
is achieved by not using a default case in the respective switch.

also a note comment was added pointing out that an observent developer
adding a new entry also needs to add it in the fromName function.

Diffs
-----

  src/propertyinfo.cpp 751f969eb9b71885323d5456ec7135874657db78 

Diff: https://git.reviewboard.kde.org/r/121266/diff/

Testing
-------

make & test

Thanks,

Harald Sitter

--===============0326373343729074536==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">  \
<tr>  <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/121266/">https://git.reviewboard.kde.org/r/121266/</a>
  </td>
    </tr>
   </table>
   <br />

<table bgcolor="#e0e0e0" width="100%" cellpadding="12" style="border: 1px gray solid; \
border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">  <tr>
  <td>
   <h1 style="margin: 0; padding: 0; font-size: 10pt;">This change has been marked as \
submitted.</h1>  </td>
 </tr>
</table>
<br />

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;">  <tr>
  <td>

<div>Review request for Baloo and Vishesh Handa.</div>
<div>By Harald Sitter.</div>

<p style="color: grey;"><i>Updated Dec. 18, 2014, 1:37 p.m.</i></p>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
kfilemetadata
</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">propertyinfotest iterates through all properties to \
make sure beginning and end are set correctly and that all properties inbetween have \
a name and description.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">this was not the case for new translation properties, \
making the test fail</p> <p style="padding: 0;text-rendering: inherit;margin: \
0;line-height: inherit;white-space: inherit;">due to the nature of this test \
iterating through everything it would also be very useful if the compiler warned \
about missing propertyinfos which is achieved by not using a default case in the \
respective switch.</p> <p style="padding: 0;text-rendering: inherit;margin: \
0;line-height: inherit;white-space: inherit;">also a note comment was added pointing \
out that an observent developer adding a new entry also needs to add it in the \
fromName function.</p></pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">make &amp; test</p></pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>src/propertyinfo.cpp <span style="color: \
grey">(751f969eb9b71885323d5456ec7135874657db78)</span></li>

</ul>

<p><a href="https://git.reviewboard.kde.org/r/121266/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

--===============0326373343729074536==--

>> Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to unsubscribe <<

[prev in list] [next in list] [prev in thread] [next in thread] 