--===============5333279495323698209== Content-Type: multipart/alternative; boundary="===============0326373343729074536==" --===============0326373343729074536== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121266/ ----------------------------------------------------------- (Updated Dec. 18, 2014, 1:37 p.m.) Status ------ This change has been marked as submitted. Review request for Baloo and Vishesh Handa. Repository: kfilemetadata Description ------- propertyinfotest iterates through all properties to make sure beginning and end are set correctly and that all properties inbetween have a name and description. this was not the case for new translation properties, making the test fail due to the nature of this test iterating through everything it would also be very useful if the compiler warned about missing propertyinfos which is achieved by not using a default case in the respective switch. also a note comment was added pointing out that an observent developer adding a new entry also needs to add it in the fromName function. Diffs ----- src/propertyinfo.cpp 751f969eb9b71885323d5456ec7135874657db78 Diff: https://git.reviewboard.kde.org/r/121266/diff/ Testing ------- make & test Thanks, Harald Sitter --===============0326373343729074536== MIME-Version: 1.0 Content-Type: text/html; charset="utf-8" Content-Transfer-Encoding: 7bit
This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121266/

This change has been marked as submitted.

Review request for Baloo and Vishesh Handa.
By Harald Sitter.

Updated Dec. 18, 2014, 1:37 p.m.

Repository: kfilemetadata

Description 

propertyinfotest iterates through all properties to make sure beginning
and end are set correctly and that all properties inbetween have a name
and description.


this was not the case for new translation properties, making the test fail


due to the nature of this test iterating through everything it would also
be very useful if the compiler warned about missing propertyinfos which
is achieved by not using a default case in the respective switch.


also a note comment was added pointing out that an observent developer
adding a new entry also needs to add it in the fromName function.

Testing 

make & test

Diffs

  • src/propertyinfo.cpp (751f969eb9b71885323d5456ec7135874657db78)

View Diff
--===============0326373343729074536==-- --===============5333279495323698209== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline >> Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to unsubscribe << --===============5333279495323698209==--