'Re: Review Request 116675: kdeexamples/plasma/c++/plasmoids/tooltips did not build'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-devel
Subject:    Re: Review Request 116675: kdeexamples/plasma/c++/plasmoids/tooltips did not build
From:       "Gregor Mi" <codestruct () posteo ! org>
Date:       2014-07-25 2:04:04
Message-ID: 20140725020404.14616.9928 () probe ! kde ! org
[Download RAW message or body]

--===============4295909619503577178==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116675/
-----------------------------------------------------------

(Updated July 25, 2014, 2:04 a.m.)

Status
------

This change has been discarded.

Review request for KDE Examples.

Repository: kdeexamples

Description
-------

1. Fix the CMakeLists.txt of kdeexamples/plasma/c++/plasmoids/tooltips (did not \
                build)
UPDATE: I just realized that the kdeexamples are supposed to be build using the \
CMakeLists.txt in the root. Therefore the fix No 1. probably makes not that much \
sense anymore.

2. add a tutorial quickstart-run.sh based on \
http://techbase.kde.org/Development/Tutorials/Plasma/GettingStarted.

3. Add .reviewboardrc

Diffs
-----

  plasma/c++/plasmoids/tooltips/.gitignore PRE-CREATION 
  plasma/c++/plasmoids/tooltips/.reviewboardrc PRE-CREATION 
  plasma/c++/plasmoids/tooltips/CMakeLists.txt \
669ad30af9572696a3fa088c6b902a480519c422   \
plasma/c++/plasmoids/tooltips/quickstart-run.sh PRE-CREATION 

Diff: https://git.reviewboard.kde.org/r/116675/diff/

Testing
-------

Thanks,

Gregor Mi

--===============4295909619503577178==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">  \
<tr>  <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/116675/">https://git.reviewboard.kde.org/r/116675/</a>
  </td>
    </tr>
   </table>
   <br />

<table bgcolor="#e0e0e0" width="100%" cellpadding="12" style="border: 1px gray solid; \
border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">  <tr>
  <td>
   <h1 style="margin: 0; padding: 0; font-size: 10pt;">This change has been \
discarded.</h1>  </td>
 </tr>
</table>
<br />

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;">  <tr>
  <td>

<div>Review request for KDE Examples.</div>
<div>By Gregor Mi.</div>

<p style="color: grey;"><i>Updated July 25, 2014, 2:04 a.m.</i></p>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
kdeexamples
</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">1. Fix the CMakeLists.txt of kdeexamples/plasma/c++/plasmoids/tooltips \
                (did not build)
UPDATE: I just realized that the kdeexamples are supposed to be build using the \
CMakeLists.txt in the root. Therefore the fix No 1. probably makes not that much \
sense anymore.

2. add a tutorial quickstart-run.sh based on \
http://techbase.kde.org/Development/Tutorials/Plasma/GettingStarted.

3. Add .reviewboardrc</pre>
  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>plasma/c++/plasmoids/tooltips/.gitignore <span style="color: \
grey">(PRE-CREATION)</span></li>

 <li>plasma/c++/plasmoids/tooltips/.reviewboardrc <span style="color: \
grey">(PRE-CREATION)</span></li>

 <li>plasma/c++/plasmoids/tooltips/CMakeLists.txt <span style="color: \
grey">(669ad30af9572696a3fa088c6b902a480519c422)</span></li>

 <li>plasma/c++/plasmoids/tooltips/quickstart-run.sh <span style="color: \
grey">(PRE-CREATION)</span></li>

</ul>

<p><a href="https://git.reviewboard.kde.org/r/116675/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

--===============4295909619503577178==--

>> Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to unsubscribe <<

[prev in list] [next in list] [prev in thread] [next in thread] 