'Re: Review Request 116675: kdeexamples/plasma/c++/plasmoids/tooltips did not build'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-devel
Subject:    Re: Review Request 116675: kdeexamples/plasma/c++/plasmoids/tooltips did not build
From:       "Gregor Mi" <codeminister () publicstatic ! de>
Date:       2014-03-09 22:52:37
Message-ID: 20140309225237.12361.30441 () probe ! kde ! org
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116675/
-----------------------------------------------------------

(Updated March 9, 2014, 10:52 p.m.)

Review request for KDE Examples.

Changes
-------

Updated first bullet point of the description 

Repository: kdeexamples

Description (updated)
-------

1. Fix the CMakeLists.txt of kdeexamples/plasma/c++/plasmoids/tooltips (did not \
                build)
UPDATE: I just realized that the kdeexamples are supposed to be build using the \
CMakeLists.txt in the root. Therefore the fix No 1. probably makes not that much \
sense anymore.

2. add a tutorial quickstart-run.sh based on \
http://techbase.kde.org/Development/Tutorials/Plasma/GettingStarted.

3. Add .reviewboardrc

Diffs
-----

  plasma/c++/plasmoids/tooltips/.gitignore PRE-CREATION 
  plasma/c++/plasmoids/tooltips/.reviewboardrc PRE-CREATION 
  plasma/c++/plasmoids/tooltips/CMakeLists.txt \
669ad30af9572696a3fa088c6b902a480519c422   \
plasma/c++/plasmoids/tooltips/quickstart-run.sh PRE-CREATION 

Diff: https://git.reviewboard.kde.org/r/116675/diff/

Testing
-------

Thanks,

Gregor Mi

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/116675/">https://git.reviewboard.kde.org/r/116675/</a>
  </td>
    </tr>
   </table>
   <br />

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for KDE Examples.</div>
<div>By Gregor Mi.</div>

<p style="color: grey;"><i>Updated March 9, 2014, 10:52 p.m.</i></p>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Updated first bullet point of the description </pre>  </td>
 </tr>
</table>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
kdeexamples
</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description  \
(updated)</h1>  <table width="100%" bgcolor="#ffffff" cellspacing="0" \
cellpadding="10" style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">1. Fix the CMakeLists.txt of kdeexamples/plasma/c++/plasmoids/tooltips \
                (did not build)
UPDATE: I just realized that the kdeexamples are supposed to be build using the \
CMakeLists.txt in the root. Therefore the fix No 1. probably makes not that much \
sense anymore.

2. add a tutorial quickstart-run.sh based on \
http://techbase.kde.org/Development/Tutorials/Plasma/GettingStarted.

3. Add .reviewboardrc</pre>
  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>plasma/c++/plasmoids/tooltips/.gitignore <span style="color: \
grey">(PRE-CREATION)</span></li>

 <li>plasma/c++/plasmoids/tooltips/.reviewboardrc <span style="color: \
grey">(PRE-CREATION)</span></li>

 <li>plasma/c++/plasmoids/tooltips/CMakeLists.txt <span style="color: \
grey">(669ad30af9572696a3fa088c6b902a480519c422)</span></li>

 <li>plasma/c++/plasmoids/tooltips/quickstart-run.sh <span style="color: \
grey">(PRE-CREATION)</span></li>

</ul>

<p><a href="https://git.reviewboard.kde.org/r/116675/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

>> Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to unsubscribe <<

[prev in list] [next in list] [prev in thread] [next in thread] 