'Re: Review Request 119319: Baloo (frameworks): install *store plugins into kf5/baloo subfolder'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-devel
Subject:    Re: Review Request 119319: Baloo (frameworks): install *store plugins into kf5/baloo subfolder
From:       Dan_Vrátil <dvratil () redhat ! com>
Date:       2014-07-22 13:33:52
Message-ID: 20140722133352.14616.1657 () probe ! kde ! org
[Download RAW message or body]

--===============4759880893820166479==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119319/
-----------------------------------------------------------

(Updated July 22, 2014, 1:33 p.m.)

Status
------

This change has been marked as submitted.

Review request for Baloo.

Repository: baloo

Description
-------

Most frameworks install their plugins to ```${PLUGINS_INSTALL_DIR}/kf5/$FRAMEWORK```. \
I think it's better than polluting the qt5/plugins directory with \
$framework_pluginname.so binaries, so let Baloo install it's store plugins into \
```${PLUGIN_INSTALL_DIR}/kf5/baloo/``` and without the ```baloo_``` prefix

Diffs
-----

  src/file/search/CMakeLists.txt 1bf2160 
  src/file/search/baloo_filesearchstore.desktop e8a4689 
  src/pim/search/calendar/CMakeLists.txt 5542203 
  src/pim/search/calendar/baloo_calendarsearchstore.desktop 898925a 
  src/pim/search/contact/CMakeLists.txt bf63f8f 
  src/pim/search/contact/baloo_contactsearchstore.desktop 42edf10 
  src/pim/search/email/CMakeLists.txt 35757e4 
  src/pim/search/email/baloo_emailsearchstore.desktop 65dea8e 
  src/pim/search/note/CMakeLists.txt 0fe03b5 
  src/pim/search/note/baloo_notesearchstore.desktop c11e28e 

Diff: https://git.reviewboard.kde.org/r/119319/diff/

Testing
-------

Thanks,

Dan Vrátil

--===============4759880893820166479==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 8bit

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">  \
<tr>  <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/119319/">https://git.reviewboard.kde.org/r/119319/</a>
  </td>
    </tr>
   </table>
   <br />

<table bgcolor="#e0e0e0" width="100%" cellpadding="12" style="border: 1px gray solid; \
border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">  <tr>
  <td>
   <h1 style="margin: 0; padding: 0; font-size: 10pt;">This change has been marked as \
submitted.</h1>  </td>
 </tr>
</table>
<br />

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;">  <tr>
  <td>

<div>Review request for Baloo.</div>
<div>By Dan Vrátil.</div>

<p style="color: grey;"><i>Updated July 22, 2014, 1:33 p.m.</i></p>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
baloo
</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Most frameworks install their plugins to <code \
style="text-rendering: inherit;color: #4444cc;padding: 0;white-space: normal;margin: \
0;line-height: inherit;">${PLUGINS_INSTALL_DIR}/kf5/$FRAMEWORK</code>. I think it's \
better than polluting the qt5/plugins directory with $framework_pluginname.so \
binaries, so let Baloo install it's store plugins into <code style="text-rendering: \
inherit;color: #4444cc;padding: 0;white-space: normal;margin: 0;line-height: \
inherit;">${PLUGIN_INSTALL_DIR}/kf5/baloo/</code> and without the <code \
style="text-rendering: inherit;color: #4444cc;padding: 0;white-space: normal;margin: \
0;line-height: inherit;">baloo_</code> prefix</p></pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>src/file/search/CMakeLists.txt <span style="color: grey">(1bf2160)</span></li>

 <li>src/file/search/baloo_filesearchstore.desktop <span style="color: \
grey">(e8a4689)</span></li>

 <li>src/pim/search/calendar/CMakeLists.txt <span style="color: \
grey">(5542203)</span></li>

 <li>src/pim/search/calendar/baloo_calendarsearchstore.desktop <span style="color: \
grey">(898925a)</span></li>

 <li>src/pim/search/contact/CMakeLists.txt <span style="color: \
grey">(bf63f8f)</span></li>

 <li>src/pim/search/contact/baloo_contactsearchstore.desktop <span style="color: \
grey">(42edf10)</span></li>

 <li>src/pim/search/email/CMakeLists.txt <span style="color: \
grey">(35757e4)</span></li>

 <li>src/pim/search/email/baloo_emailsearchstore.desktop <span style="color: \
grey">(65dea8e)</span></li>

 <li>src/pim/search/note/CMakeLists.txt <span style="color: \
grey">(0fe03b5)</span></li>

 <li>src/pim/search/note/baloo_notesearchstore.desktop <span style="color: \
grey">(c11e28e)</span></li>

</ul>

<p><a href="https://git.reviewboard.kde.org/r/119319/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

--===============4759880893820166479==--

>> Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to unsubscribe <<

[prev in list] [next in list] [prev in thread] [next in thread] 