[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-devel
Subject: Re: Review Request 119318: Baloo (frameworks): Install kio slaves into correct folder
From: Dan_Vrátil <dvratil () redhat ! com>
Date: 2014-07-22 13:33:51
Message-ID: 20140722133351.14616.43971 () probe ! kde ! org
[Download RAW message or body]
--===============4945726012066122668==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119318/
-----------------------------------------------------------
(Updated July 22, 2014, 1:33 p.m.)
Status
------
This change has been marked as submitted.
Review request for Baloo.
Repository: baloo
Description
-------
The KIO Framework installs it's kioslaves into ```%{PLUGINS_INSTALL_DIR}/kf5/kio``` \
and without the ```kio_``` prefix, so let's do the same in Baloo
Diffs
-----
src/kioslaves/search/CMakeLists.txt 4a1bf69
src/kioslaves/search/baloosearch.protocol f241ac6
src/kioslaves/tags/CMakeLists.txt f379834
src/kioslaves/tags/tags.protocol f14af6d
src/kioslaves/timeline/CMakeLists.txt 7c9e35c
src/kioslaves/timeline/timeline.protocol 81f814e
Diff: https://git.reviewboard.kde.org/r/119318/diff/
Testing
-------
Thanks,
Dan Vrátil
--===============4945726012066122668==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 8bit
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> \
<tr> <td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/119318/">https://git.reviewboard.kde.org/r/119318/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#e0e0e0" width="100%" cellpadding="12" style="border: 1px gray solid; \
border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> <tr>
<td>
<h1 style="margin: 0; padding: 0; font-size: 10pt;">This change has been marked as \
submitted.</h1> </td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;"> <tr>
<td>
<div>Review request for Baloo.</div>
<div>By Dan Vrátil.</div>
<p style="color: grey;"><i>Updated July 22, 2014, 1:33 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
baloo
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">The KIO Framework installs it's kioslaves into <code \
style="text-rendering: inherit;color: #4444cc;padding: 0;white-space: normal;margin: \
0;line-height: inherit;">%{PLUGINS_INSTALL_DIR}/kf5/kio</code> and without the <code \
style="text-rendering: inherit;color: #4444cc;padding: 0;white-space: normal;margin: \
0;line-height: inherit;">kio_</code> prefix, so let's do the same in Baloo</p></pre> \
</td> </tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/kioslaves/search/CMakeLists.txt <span style="color: \
grey">(4a1bf69)</span></li>
<li>src/kioslaves/search/baloosearch.protocol <span style="color: \
grey">(f241ac6)</span></li>
<li>src/kioslaves/tags/CMakeLists.txt <span style="color: \
grey">(f379834)</span></li>
<li>src/kioslaves/tags/tags.protocol <span style="color: grey">(f14af6d)</span></li>
<li>src/kioslaves/timeline/CMakeLists.txt <span style="color: \
grey">(7c9e35c)</span></li>
<li>src/kioslaves/timeline/timeline.protocol <span style="color: \
grey">(81f814e)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/119318/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============4945726012066122668==--
>> Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to unsubscribe <<
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic