[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-devel
Subject: Re: Review Request 118231: Scheduler for the akonadi indexer.
From: "Vishesh Handa" <me () vhanda ! in>
Date: 2014-07-03 21:10:45
Message-ID: 20140703211045.17149.23556 () probe ! kde ! org
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118231/#review61574
-----------------------------------------------------------
I still haven't had time to look into the latest code, but that's my problem. This \
has been lying here for too long.
Christian, if you're comfortable with the current scheduler, then please push it. You \
clearly want scheduling in the indexing. I disapprove, but you're much more active in \
the PIM community these days. You get to decide.
- Vishesh Handa
On June 3, 2014, 11:18 p.m., Christian Mollekopf wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/118231/
> -----------------------------------------------------------
>
> (Updated June 3, 2014, 11:18 p.m.)
>
>
> Review request for Baloo and Vishesh Handa.
>
>
> Repository: baloo
>
>
> Description
> -------
>
> A scheduler for baloo:
> * delays the indexing until no new item has been added for at least 5 seconds to \
> avoid indexing during a collection sync.
> * remembers if it failed to index something and triggers recovery path on next \
> start.
> * supports manual triggering of recovery path if required.
>
>
> Diffs
> -----
>
> src/file/fileexcludefilters.cpp e1f2ed7f64353d098327e5eff44a5e5a17a48da2
> src/pim/agent/CMakeLists.txt e917915a3414738595caea5497859ef4810ec44c
> src/pim/agent/agent.h 1dbf0fc0a16d0615dbfa4878706359bb687facd0
> src/pim/agent/agent.cpp 8904d49d3579b58b634d2570fbcc8007e5ee41ed
> src/pim/agent/autotests/CMakeLists.txt 5ee987aad0d09c28da868ac8cd1c308f673bb7bf
> src/pim/agent/autotests/collectionindexingjobtest.cpp PRE-CREATION
> src/pim/agent/autotests/schedulertest.cpp PRE-CREATION
> src/pim/agent/autotests/unittestenv/config-mysql-db.xml PRE-CREATION
> src/pim/agent/autotests/unittestenv/config-sqlite-db.xml PRE-CREATION
> src/pim/agent/autotests/unittestenv/kdehome/share/config/akonadi-firstrunrc \
> PRE-CREATION src/pim/agent/autotests/unittestenv/kdehome/share/config/akonadi_knut_resource_0rc \
> PRE-CREATION src/pim/agent/autotests/unittestenv/kdehome/share/config/kdebugrc \
> PRE-CREATION src/pim/agent/autotests/unittestenv/kdehome/share/config/kdedrc \
> PRE-CREATION src/pim/agent/autotests/unittestenv/kdehome/testdata-res1.xml \
> PRE-CREATION src/pim/agent/autotests/unittestenv/xdgconfig/akonadi/akonadiserverrc \
> PRE-CREATION src/pim/agent/collectionindexingjob.h PRE-CREATION
> src/pim/agent/collectionindexingjob.cpp PRE-CREATION
> src/pim/agent/index.h PRE-CREATION
> src/pim/agent/index.cpp PRE-CREATION
> src/pim/agent/scheduler.h PRE-CREATION
> src/pim/agent/scheduler.cpp PRE-CREATION
>
> Diff: https://git.reviewboard.kde.org/r/118231/diff/
>
>
> Testing
> -------
>
> I'm running it for a while, and it reduced the stress that baloo imposed on my \
> system and all my mails are indexed since I'm using it (wasn't the case before).
>
> Thanks,
>
> Christian Mollekopf
>
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/118231/">https://git.reviewboard.kde.org/r/118231/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I still haven't had \
time to look into the latest code, but that's my problem. This has been lying \
here for too long.
Christian, if you're comfortable with the current scheduler, then please push it. \
You clearly want scheduling in the indexing. I disapprove, but you're much more \
active in the PIM community these days. You get to decide.</pre> <br />
<p>- Vishesh Handa</p>
<br />
<p>On June 3rd, 2014, 11:18 p.m. UTC, Christian Mollekopf wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for Baloo and Vishesh Handa.</div>
<div>By Christian Mollekopf.</div>
<p style="color: grey;"><i>Updated June 3, 2014, 11:18 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
baloo
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">A scheduler for baloo:
* delays the indexing until no new item has been added for at least 5 seconds to \
avoid indexing during a collection sync.
* remembers if it failed to index something and triggers recovery path on next start.
* supports manual triggering of recovery path if required.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">I'm running it for a while, and it reduced the stress that baloo \
imposed on my system and all my mails are indexed since I'm using it (wasn't \
the case before).</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/file/fileexcludefilters.cpp <span style="color: \
grey">(e1f2ed7f64353d098327e5eff44a5e5a17a48da2)</span></li>
<li>src/pim/agent/CMakeLists.txt <span style="color: \
grey">(e917915a3414738595caea5497859ef4810ec44c)</span></li>
<li>src/pim/agent/agent.h <span style="color: \
grey">(1dbf0fc0a16d0615dbfa4878706359bb687facd0)</span></li>
<li>src/pim/agent/agent.cpp <span style="color: \
grey">(8904d49d3579b58b634d2570fbcc8007e5ee41ed)</span></li>
<li>src/pim/agent/autotests/CMakeLists.txt <span style="color: \
grey">(5ee987aad0d09c28da868ac8cd1c308f673bb7bf)</span></li>
<li>src/pim/agent/autotests/collectionindexingjobtest.cpp <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>src/pim/agent/autotests/schedulertest.cpp <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>src/pim/agent/autotests/unittestenv/config-mysql-db.xml <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>src/pim/agent/autotests/unittestenv/config-sqlite-db.xml <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>src/pim/agent/autotests/unittestenv/kdehome/share/config/akonadi-firstrunrc \
<span style="color: grey">(PRE-CREATION)</span></li>
<li>src/pim/agent/autotests/unittestenv/kdehome/share/config/akonadi_knut_resource_0rc \
<span style="color: grey">(PRE-CREATION)</span></li>
<li>src/pim/agent/autotests/unittestenv/kdehome/share/config/kdebugrc <span \
style="color: grey">(PRE-CREATION)</span></li>
<li>src/pim/agent/autotests/unittestenv/kdehome/share/config/kdedrc <span \
style="color: grey">(PRE-CREATION)</span></li>
<li>src/pim/agent/autotests/unittestenv/kdehome/testdata-res1.xml <span \
style="color: grey">(PRE-CREATION)</span></li>
<li>src/pim/agent/autotests/unittestenv/xdgconfig/akonadi/akonadiserverrc <span \
style="color: grey">(PRE-CREATION)</span></li>
<li>src/pim/agent/collectionindexingjob.h <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>src/pim/agent/collectionindexingjob.cpp <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>src/pim/agent/index.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/pim/agent/index.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/pim/agent/scheduler.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/pim/agent/scheduler.cpp <span style="color: grey">(PRE-CREATION)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/118231/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
>> Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to unsubscribe <<
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic