[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-devel
Subject: Re: Review Request 118438: Add an option to only build baloo's libraries
From: "Heiko Becker" <heirecka () exherbo ! org>
Date: 2014-06-18 8:41:38
Message-ID: 20140618084138.20798.28969 () probe ! kde ! org
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118438/
-----------------------------------------------------------
(Updated June 18, 2014, 8:41 a.m.)
Review request for Baloo.
Changes
-------
The old patch didn't apply anymore.
And as a notice: I don't have push access.
Repository: baloo
Description
-------
The intention behind this review request is to make it easier to turn baloo \
into a framework and make it coinstallable with its KDE4 counterpart in a \
second review request.
That being said I'm not exactly sure this is the way you guys want to go, \
but I'd be willing to update my review request accordingly if you have \
other plans to make it coinstallable.
Diffs (updated)
-----
src/CMakeLists.txt 810f6dcd97b5f3ff64962709efbfffec7fa9a257
src/file/CMakeLists.txt dd2e2b2a9fdddefe5568d51427cf69103b1bdd85
Diff: https://git.reviewboard.kde.org/r/118438/diff/
Testing
-------
cmake -DBALOO_LIBRARIES_ONLY:BOOL=TRUE ..
make
make install
I've also built the frameworks branch of milou against it (needed a few \
modifications).
Thanks,
Heiko Becker
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px \
#c9c399 solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/118438/">https://git.reviewboard.kde.org/r/118438/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px \
black solid;"> <tr>
<td>
<div>Review request for Baloo.</div>
<div>By Heiko Becker.</div>
<p style="color: grey;"><i>Updated June 18, 2014, 8:41 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: \
1.5em;">Changes</h1> <table width="100%" bgcolor="#ffffff" cellspacing="0" \
cellpadding="10" style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">The old patch didn't apply anymore.
And as a notice: I don't have push access.</pre>
</td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
baloo
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description \
</h1> <table width="100%" bgcolor="#ffffff" cellspacing="0" \
cellpadding="10" style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">The intention behind this review request is to make it easier \
to turn baloo into a framework and make it coinstallable with its KDE4 \
counterpart in a second review request.
That being said I'm not exactly sure this is the way you guys want to \
go, but I'd be willing to update my review request accordingly if you \
have other plans to make it coinstallable.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing \
</h1> <table width="100%" bgcolor="#ffffff" cellspacing="0" \
cellpadding="10" style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">cmake -DBALOO_LIBRARIES_ONLY:BOOL=TRUE .. make
make install
I've also built the frameworks branch of milou against it (needed a few \
modifications).</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> \
(updated)</h1> <ul style="margin-left: 3em; padding-left: 0;">
<li>src/CMakeLists.txt <span style="color: \
grey">(810f6dcd97b5f3ff64962709efbfffec7fa9a257)</span></li>
<li>src/file/CMakeLists.txt <span style="color: \
grey">(dd2e2b2a9fdddefe5568d51427cf69103b1bdd85)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/118438/diff/" \
style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
>> Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to unsubscribe <<
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic