--===============1201667624618138428== Content-Type: multipart/alternative; boundary="===============2301525650398236752==" --===============2301525650398236752== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118438/ ----------------------------------------------------------- (Updated June 18, 2014, 8:41 a.m.) Review request for Baloo. Changes ------- The old patch didn't apply anymore. And as a notice: I don't have push access. Repository: baloo Description ------- The intention behind this review request is to make it easier to turn baloo into a framework and make it coinstallable with its KDE4 counterpart in a second review request. That being said I'm not exactly sure this is the way you guys want to go, but I'd be willing to update my review request accordingly if you have other plans to make it coinstallable. Diffs (updated) ----- src/CMakeLists.txt 810f6dcd97b5f3ff64962709efbfffec7fa9a257 src/file/CMakeLists.txt dd2e2b2a9fdddefe5568d51427cf69103b1bdd85 Diff: https://git.reviewboard.kde.org/r/118438/diff/ Testing ------- cmake -DBALOO_LIBRARIES_ONLY:BOOL=TRUE .. make make install I've also built the frameworks branch of milou against it (needed a few modifications). Thanks, Heiko Becker --===============2301525650398236752== Content-Type: text/html; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit

This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118438/

Review request for Baloo.

By Heiko Becker.

Updated June 18, 2014, 8:41 a.m.

Changes

The old patch didn't apply anymore.

And as a notice: I don't have push access.

Repository: baloo

Description

The intention behind this review request is to make it easier to turn baloo into a framework and make it coinstallable with its KDE4 counterpart in a second review request.

That being said I'm not exactly sure this is the way you guys want to go, but I'd be willing to update my review request accordingly if you have other plans to make it coinstallable.

Testing

cmake -DBALOO_LIBRARIES_ONLY:BOOL=TRUE ..
make
make install

I've also built the frameworks branch of milou against it (needed a few modifications).

Diffs (updated)

src/CMakeLists.txt (810f6dcd97b5f3ff64962709efbfffec7fa9a257)
src/file/CMakeLists.txt (dd2e2b2a9fdddefe5568d51427cf69103b1bdd85)

--===============2301525650398236752==-- --===============1201667624618138428== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline >> Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to unsubscribe << --===============1201667624618138428==--