[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-devel
Subject: Re: Review Request 118438: Add an option to only build baloo's libraries
From: "Heiko Becker" <heirecka () exherbo ! org>
Date: 2014-06-11 16:57:13
Message-ID: 20140611165713.27400.41643 () probe ! kde ! org
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
> On June 4, 2014, 2:55 p.m., Vishesh Handa wrote:
> > I'm not too sure about this. I was planning on moving the runners, kcm and \
> > kioslaves out of the baloo repository and into plasma-desktop and \
> > plasma-workspace. This just leaves the executables, which IMO should overwrite \
> > the old ones, but that would be a problem, right?
Well, splitting it out would work for us, too. So that leaves the binaries. If they \
shouldn't be renamed it would to nice to have a cmake option in order to decide if \
they should be build. That way we could provide packages with an option allowing the \
user to build and install the binaries for the version he wants (probably matching \
his version of Plasma workspaces).
I'd be willing to adjust this patch to only make the building of binaries depending \
on a cmake option, if it's alright with you.
- Heiko
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118438/#review59206
-----------------------------------------------------------
On May 31, 2014, 11:54 a.m., Heiko Becker wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/118438/
> -----------------------------------------------------------
>
> (Updated May 31, 2014, 11:54 a.m.)
>
>
> Review request for Baloo.
>
>
> Repository: baloo
>
>
> Description
> -------
>
> The intention behind this review request is to make it easier to turn baloo into a \
> framework and make it coinstallable with its KDE4 counterpart in a second review \
> request.
> That being said I'm not exactly sure this is the way you guys want to go, but I'd \
> be willing to update my review request accordingly if you have other plans to make \
> it coinstallable.
>
> Diffs
> -----
>
> src/CMakeLists.txt de044025012ebcccb8a9c7293edfe045cc9b7856
> src/file/CMakeLists.txt 4f9fb9dd6b0e680a5f70cfaeb3986000cb192acd
>
> Diff: https://git.reviewboard.kde.org/r/118438/diff/
>
>
> Testing
> -------
>
> cmake -DBALOO_LIBRARIES_ONLY:BOOL=TRUE ..
> make
> make install
>
> I've also built the frameworks branch of milou against it (needed a few \
> modifications).
>
> Thanks,
>
> Heiko Becker
>
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/118438/">https://git.reviewboard.kde.org/r/118438/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On June 4th, 2014, 2:55 p.m. UTC, <b>Vishesh \
Handa</b> wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px solid \
#d0d0d0; padding-left: 10px;"> <pre style="white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">I'm not too sure about this. I was planning on moving the runners, \
kcm and kioslaves out of the baloo repository and into plasma-desktop and \
plasma-workspace. This just leaves the executables, which IMO should overwrite the \
old ones, but that would be a problem, right?</pre> </blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Well, splitting it out \
would work for us, too. So that leaves the binaries. If they shouldn't be renamed \
it would to nice to have a cmake option in order to decide if they should be build. \
That way we could provide packages with an option allowing the user to build and \
install the binaries for the version he wants (probably matching his version of \
Plasma workspaces).
I'd be willing to adjust this patch to only make the building of binaries \
depending on a cmake option, if it's alright with you. </pre>
<br />
<p>- Heiko</p>
<br />
<p>On May 31st, 2014, 11:54 a.m. UTC, Heiko Becker wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for Baloo.</div>
<div>By Heiko Becker.</div>
<p style="color: grey;"><i>Updated May 31, 2014, 11:54 a.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
baloo
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">The intention behind this review request is to make it easier to turn \
baloo into a framework and make it coinstallable with its KDE4 counterpart in a \
second review request.
That being said I'm not exactly sure this is the way you guys want to go, but \
I'd be willing to update my review request accordingly if you have other plans to \
make it coinstallable.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">cmake -DBALOO_LIBRARIES_ONLY:BOOL=TRUE .. make
make install
I've also built the frameworks branch of milou against it (needed a few \
modifications).</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/CMakeLists.txt <span style="color: \
grey">(de044025012ebcccb8a9c7293edfe045cc9b7856)</span></li>
<li>src/file/CMakeLists.txt <span style="color: \
grey">(4f9fb9dd6b0e680a5f70cfaeb3986000cb192acd)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/118438/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
>> Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to unsubscribe <<
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic