'Re: Review Request 118439: Turn baloo's libraries into a framework'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-devel
Subject:    Re: Review Request 118439: Turn baloo's libraries into a framework
From:       "Heiko Becker" <heirecka () exherbo ! org>
Date:       2014-06-11 13:03:07
Message-ID: 20140611130307.10453.23171 () probe ! kde ! org
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118439/
-----------------------------------------------------------

(Updated June 11, 2014, 1:03 p.m.)

Status
------

This change has been marked as submitted.

Review request for Baloo.

Repository: baloo

Description
-------

This turns baloo's libraries into a framework to make it coinstallable with its KDE4 \
counterpart.

As I've said in my first review request (https://git.reviewboard.kde.org/r/118438/) \
I'm not exactly sure this is the way you guys want to go, but I'd be willing to \
update my review request accordingly if you have other plans to make it \
coinstallable.

Diffs
-----

  BalooConfig.cmake.in d389bfd69def803b3bceb1a79ce4c97e4ea4803e 
  CMakeLists.txt fe6b24195eb39d9113004169bf119f4fe991e32b 
  src/core/CMakeLists.txt 844100f5e3ac9aebfb0d267f63742d63d2ad2965 
  src/core/autotests/CMakeLists.txt d03b0a71848ea3a816d1d4c2ebcf1981e54ba710 
  src/core/tests/CMakeLists.txt f505379c4b0da41c68e1945f3ae3b7ddccd57910 
  src/file/lib/CMakeLists.txt 9bfafde198d5033bf1f1558aa7727d109b2c673d 
  src/file/lib/autotests/CMakeLists.txt 0c20b65cf2302bdf1e39d9fc380fd371e699734e 
  src/xapian/CMakeLists.txt 5fcfd090ae479a8a79a37a3e6d0b6246d971a916 

Diff: https://git.reviewboard.kde.org/r/118439/diff/

Testing
-------

cmake -DBALOO_LIBRARIES_ONLY:BOOL=TRUE ..
make
make install

I've also built the frameworks branch of milou against it (needed a few \
modifications).

Thanks,

Heiko Becker

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/118439/">https://git.reviewboard.kde.org/r/118439/</a>
  </td>
    </tr>
   </table>
   <br />

<table bgcolor="#e0e0e0" width="100%" cellpadding="8" style="border: 1px gray \
solid;">  <tr>
  <td>
   <h1 style="margin-right: 0.2em; padding: 0; font-size: 10pt;">This change has been \
marked as submitted.</h1>  </td>
 </tr>
</table>
<br />

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for Baloo.</div>
<div>By Heiko Becker.</div>

<p style="color: grey;"><i>Updated June 11, 2014, 1:03 p.m.</i></p>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
baloo
</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">This turns baloo&#39;s libraries into a framework to make it \
coinstallable with its KDE4 counterpart.

As I&#39;ve said in my first review request \
(https://git.reviewboard.kde.org/r/118438/) I&#39;m not exactly sure this is the way \
you guys want to go, but I&#39;d be willing to update my review request accordingly \
if you have other plans to make it coinstallable.</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">cmake -DBALOO_LIBRARIES_ONLY:BOOL=TRUE .. make
make install

I&#39;ve also built the frameworks branch of milou against it (needed a few \
modifications).</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>BalooConfig.cmake.in <span style="color: \
grey">(d389bfd69def803b3bceb1a79ce4c97e4ea4803e)</span></li>

 <li>CMakeLists.txt <span style="color: \
grey">(fe6b24195eb39d9113004169bf119f4fe991e32b)</span></li>

 <li>src/core/CMakeLists.txt <span style="color: \
grey">(844100f5e3ac9aebfb0d267f63742d63d2ad2965)</span></li>

 <li>src/core/autotests/CMakeLists.txt <span style="color: \
grey">(d03b0a71848ea3a816d1d4c2ebcf1981e54ba710)</span></li>

 <li>src/core/tests/CMakeLists.txt <span style="color: \
grey">(f505379c4b0da41c68e1945f3ae3b7ddccd57910)</span></li>

 <li>src/file/lib/CMakeLists.txt <span style="color: \
grey">(9bfafde198d5033bf1f1558aa7727d109b2c673d)</span></li>

 <li>src/file/lib/autotests/CMakeLists.txt <span style="color: \
grey">(0c20b65cf2302bdf1e39d9fc380fd371e699734e)</span></li>

 <li>src/xapian/CMakeLists.txt <span style="color: \
grey">(5fcfd090ae479a8a79a37a3e6d0b6246d971a916)</span></li>

</ul>

<p><a href="https://git.reviewboard.kde.org/r/118439/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

>> Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to unsubscribe <<

[prev in list] [next in list] [prev in thread] [next in thread] 