[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-devel
Subject: Re: Review Request 117902: Use PUBLIC and PRIVATE in target_link_libraries for the installed libs
From: "Vishesh Handa" <me () vhanda ! in>
Date: 2014-05-05 13:59:44
Message-ID: 20140505135944.19582.13336 () probe ! kde ! org
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117902/#review57313
-----------------------------------------------------------
Ship it!
Sorry, I didn't notice.
- Vishesh Handa
On April 30, 2014, 2:03 p.m., Alexander Richardson wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/117902/
> -----------------------------------------------------------
>
> (Updated April 30, 2014, 2:03 p.m.)
>
>
> Review request for Baloo.
>
>
> Repository: baloo
>
>
> Description
> -------
>
> Use PUBLIC and PRIVATE in target_link_libraries for the installed libs
>
>
> Diffs
> -----
>
> src/core/CMakeLists.txt f9f663b1c1ba4c84057e76da09903c7a7c53da45
> src/file/CMakeLists.txt 79a22551f0a8fa7475b69930c381057b42ca10fb
> src/file/autotest/CMakeLists.txt a476a8d273bf9674221868f1cf287cd100191c76
> src/file/extractor/CMakeLists.txt d8abe98c23b95440e0320b158f44cdca6428e7a6
> src/file/lib/CMakeLists.txt a432ebb17ba6b66065ade31240217020b2df2ba4
> src/file/lib/autotests/CMakeLists.txt 9676c2e01c980ddb36c18a44ac1d8d08f862d1ea
> src/file/tests/CMakeLists.txt f8386ae735e3bbc24f51402e59d5fc701afddd8d
> src/pim/lib/CMakeLists.txt b57340872800ead1fcd224235b2f7b6f3f8ad172
> src/xapian/CMakeLists.txt 38a4b2ed08db52cc8e2bc1e09ad3290bb6122515
>
> Diff: https://git.reviewboard.kde.org/r/117902/diff/
>
>
> Testing
> -------
>
> No longer need to find the private dependencies when building dolphin (frameworks)
>
>
> Thanks,
>
> Alexander Richardson
>
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/117902/">https://git.reviewboard.kde.org/r/117902/</a>
</td>
</tr>
</table>
<br />
<p>Ship it!</p>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Sorry, I didn't \
notice.</pre> <br />
<p>- Vishesh Handa</p>
<br />
<p>On April 30th, 2014, 2:03 p.m. UTC, Alexander Richardson wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for Baloo.</div>
<div>By Alexander Richardson.</div>
<p style="color: grey;"><i>Updated April 30, 2014, 2:03 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
baloo
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Use PUBLIC and PRIVATE in target_link_libraries for the installed \
libs</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">No longer need to find the private dependencies when building dolphin \
(frameworks)</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/core/CMakeLists.txt <span style="color: \
grey">(f9f663b1c1ba4c84057e76da09903c7a7c53da45)</span></li>
<li>src/file/CMakeLists.txt <span style="color: \
grey">(79a22551f0a8fa7475b69930c381057b42ca10fb)</span></li>
<li>src/file/autotest/CMakeLists.txt <span style="color: \
grey">(a476a8d273bf9674221868f1cf287cd100191c76)</span></li>
<li>src/file/extractor/CMakeLists.txt <span style="color: \
grey">(d8abe98c23b95440e0320b158f44cdca6428e7a6)</span></li>
<li>src/file/lib/CMakeLists.txt <span style="color: \
grey">(a432ebb17ba6b66065ade31240217020b2df2ba4)</span></li>
<li>src/file/lib/autotests/CMakeLists.txt <span style="color: \
grey">(9676c2e01c980ddb36c18a44ac1d8d08f862d1ea)</span></li>
<li>src/file/tests/CMakeLists.txt <span style="color: \
grey">(f8386ae735e3bbc24f51402e59d5fc701afddd8d)</span></li>
<li>src/pim/lib/CMakeLists.txt <span style="color: \
grey">(b57340872800ead1fcd224235b2f7b6f3f8ad172)</span></li>
<li>src/xapian/CMakeLists.txt <span style="color: \
grey">(38a4b2ed08db52cc8e2bc1e09ad3290bb6122515)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/117902/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
>> Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to unsubscribe <<
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic