[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-devel
Subject: Re: Review Request 117828: prevent ex/import in exported classes used in tests
From: "Patrick Spendrin" <ps_ml () gmx ! de>
Date: 2014-04-28 14:43:17
Message-ID: 20140428144317.12926.27637 () probe ! kde ! org
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117828/
-----------------------------------------------------------
(Updated April 28, 2014, 2:43 p.m.)
Status
------
This change has been marked as submitted.
Review request for Baloo and kdewin.
Repository: baloo
Description
-------
If using class definitions of exported classes in tests, the export/import mechanism \
isn't needed. To prevent linker errors, set the EXPORT macro to empty.
Diffs
-----
src/file/autotest/CMakeLists.txt a54736e
src/file/autotest/fileindexingjob/CMakeLists.txt 811ed30
src/file/lib/autotests/CMakeLists.txt 95a0916
src/file/search/autotest/CMakeLists.txt eb058d2
src/file/tests/CMakeLists.txt 102c981
Diff: https://git.reviewboard.kde.org/r/117828/diff/
Testing
-------
windows msvc 2010
Thanks,
Patrick Spendrin
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/117828/">https://git.reviewboard.kde.org/r/117828/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#e0e0e0" width="100%" cellpadding="8" style="border: 1px gray \
solid;"> <tr>
<td>
<h1 style="margin-right: 0.2em; padding: 0; font-size: 10pt;">This change has been \
marked as submitted.</h1> </td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for Baloo and kdewin.</div>
<div>By Patrick Spendrin.</div>
<p style="color: grey;"><i>Updated April 28, 2014, 2:43 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
baloo
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">If using class definitions of exported classes in tests, the \
export/import mechanism isn't needed. To prevent linker errors, set the EXPORT \
macro to empty.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">windows msvc 2010</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/file/autotest/CMakeLists.txt <span style="color: grey">(a54736e)</span></li>
<li>src/file/autotest/fileindexingjob/CMakeLists.txt <span style="color: \
grey">(811ed30)</span></li>
<li>src/file/lib/autotests/CMakeLists.txt <span style="color: \
grey">(95a0916)</span></li>
<li>src/file/search/autotest/CMakeLists.txt <span style="color: \
grey">(eb058d2)</span></li>
<li>src/file/tests/CMakeLists.txt <span style="color: grey">(102c981)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/117828/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
>> Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to unsubscribe <<
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic