From kde-devel Mon Apr 28 14:43:17 2014 From: "Patrick Spendrin" Date: Mon, 28 Apr 2014 14:43:17 +0000 To: kde-devel Subject: Re: Review Request 117828: prevent ex/import in exported classes used in tests Message-Id: <20140428144317.12926.27637 () probe ! kde ! org> X-MARC-Message: https://marc.info/?l=kde-devel&m=139869626729089 MIME-Version: 1 Content-Type: multipart/mixed; boundary="--===============6537403925701853401==" --===============6537403925701853401== Content-Type: multipart/alternative; boundary="===============3203168485738511390==" --===============3203168485738511390== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117828/ ----------------------------------------------------------- (Updated April 28, 2014, 2:43 p.m.) Status ------ This change has been marked as submitted. Review request for Baloo and kdewin. Repository: baloo Description ------- If using class definitions of exported classes in tests, the export/import mechanism isn't needed. To prevent linker errors, set the EXPORT macro to empty. Diffs ----- src/file/autotest/CMakeLists.txt a54736e src/file/autotest/fileindexingjob/CMakeLists.txt 811ed30 src/file/lib/autotests/CMakeLists.txt 95a0916 src/file/search/autotest/CMakeLists.txt eb058d2 src/file/tests/CMakeLists.txt 102c981 Diff: https://git.reviewboard.kde.org/r/117828/diff/ Testing ------- windows msvc 2010 Thanks, Patrick Spendrin --===============3203168485738511390== Content-Type: text/html; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit
This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117828/

This change has been marked as submitted.

Review request for Baloo and kdewin.
By Patrick Spendrin.

Updated April 28, 2014, 2:43 p.m.

Repository: baloo

Description 

If using class definitions of exported classes in tests, the export/import mechanism isn't needed. To prevent linker errors, set the EXPORT macro to empty.

Testing 

windows msvc 2010

Diffs

  • src/file/autotest/CMakeLists.txt (a54736e)
  • src/file/autotest/fileindexingjob/CMakeLists.txt (811ed30)
  • src/file/lib/autotests/CMakeLists.txt (95a0916)
  • src/file/search/autotest/CMakeLists.txt (eb058d2)
  • src/file/tests/CMakeLists.txt (102c981)

View Diff
--===============3203168485738511390==-- --===============6537403925701853401== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline >> Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to unsubscribe << --===============6537403925701853401==--