'Re: Review Request 117420: Fixes issue with full path of excluded directory not being shown'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-devel
Subject:    Re: Review Request 117420: Fixes issue with full path of excluded directory not being shown
From:       "Lindsay Mathieson" <lindsay.mathieson () gmail ! com>
Date:       2014-04-12 23:01:02
Message-ID: 20140412230102.8159.31746 () probe ! kde ! org
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117420/
-----------------------------------------------------------

(Updated April 13, 2014, 9:01 a.m.)

Review request for Baloo.

Changes
-------

- Modifies iconName() to returns home icon or drive icon for any path starting with \
                home or mount point respectively
- Home Path display as "" rather than "[~]/"
- adds const to getFolderDisplayName()

Bugs: 333155
    http://bugs.kde.org/show_bug.cgi?id=333155

Repository: baloo

Description
-------

Displays full path of excluded directories - reduce possibilities of confusion and \
ambiguity.

Diffs (updated)
-----

  src/file/kcm/folderselectionwidget.h 5e4e661 
  src/file/kcm/folderselectionwidget.cpp bc87a33 

Diff: https://git.reviewboard.kde.org/r/117420/diff/

Testing
-------

Build, installed - opens KCM module, full paths displayed, with ample room.

Thanks,

Lindsay Mathieson

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/117420/">https://git.reviewboard.kde.org/r/117420/</a>
  </td>
    </tr>
   </table>
   <br />

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for Baloo.</div>
<div>By Lindsay Mathieson.</div>

<p style="color: grey;"><i>Updated April 13, 2014, 9:01 a.m.</i></p>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">- Modifies iconName() to returns home icon or drive icon for any path \
                starting with home or mount point respectively
- Home Path display as &quot;&quot; rather than &quot;[~]/&quot;
- adds const to getFolderDisplayName()</pre>
  </td>
 </tr>
</table>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>

 <a href="http://bugs.kde.org/show_bug.cgi?id=333155">333155</a>

</div>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
baloo
</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Displays full path of excluded directories - reduce possibilities of \
confusion and ambiguity.</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Build, installed - opens KCM module, full paths displayed, with ample \
room.</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> \
(updated)</h1> <ul style="margin-left: 3em; padding-left: 0;">

 <li>src/file/kcm/folderselectionwidget.h <span style="color: \
grey">(5e4e661)</span></li>

 <li>src/file/kcm/folderselectionwidget.cpp <span style="color: \
grey">(bc87a33)</span></li>

</ul>

<p><a href="https://git.reviewboard.kde.org/r/117420/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

>> Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to unsubscribe <<

[prev in list] [next in list] [prev in thread] [next in thread] 