From kde-devel Sat Apr 12 23:01:02 2014 From: "Lindsay Mathieson" Date: Sat, 12 Apr 2014 23:01:02 +0000 To: kde-devel Subject: Re: Review Request 117420: Fixes issue with full path of excluded directory not being shown Message-Id: <20140412230102.8159.31746 () probe ! kde ! org> X-MARC-Message: https://marc.info/?l=kde-devel&m=139734369314409 MIME-Version: 1 Content-Type: multipart/mixed; boundary="--===============8448289457398763916==" --===============8448289457398763916== Content-Type: multipart/alternative; boundary="===============0405932369855308059==" --===============0405932369855308059== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117420/ ----------------------------------------------------------- (Updated April 13, 2014, 9:01 a.m.) Review request for Baloo. Changes ------- - Modifies iconName() to returns home icon or drive icon for any path starting with home or mount point respectively - Home Path display as "" rather than "[~]/" - adds const to getFolderDisplayName() Bugs: 333155 http://bugs.kde.org/show_bug.cgi?id=333155 Repository: baloo Description ------- Displays full path of excluded directories - reduce possibilities of confusion and ambiguity. Diffs (updated) ----- src/file/kcm/folderselectionwidget.h 5e4e661 src/file/kcm/folderselectionwidget.cpp bc87a33 Diff: https://git.reviewboard.kde.org/r/117420/diff/ Testing ------- Build, installed - opens KCM module, full paths displayed, with ample room. Thanks, Lindsay Mathieson --===============0405932369855308059== Content-Type: text/html; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit

This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117420/

Review request for Baloo.

By Lindsay Mathieson.

Updated April 13, 2014, 9:01 a.m.

Changes

- Modifies iconName() to returns home icon or drive icon for any path starting with home or mount point respectively
- Home Path display as "" rather than "[~]/"
- adds const to getFolderDisplayName()

Bugs: 333155

Repository: baloo

Description

Displays full path of excluded directories - reduce possibilities of confusion and ambiguity.

Testing

Build, installed - opens KCM module, full paths displayed, with ample room.

Diffs (updated)

src/file/kcm/folderselectionwidget.h (5e4e661)
src/file/kcm/folderselectionwidget.cpp (bc87a33)

View Diff

--===============0405932369855308059==-- --===============8448289457398763916== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline >> Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to unsubscribe << --===============8448289457398763916==--