[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-devel
Subject: Re: Review Request 116764: Baloo: Use XDG_DATA_HOME instead of KDE HOME
From: "Kevin Krammer" <krammer () kde ! org>
Date: 2014-03-12 16:24:03
Message-ID: 20140312162403.32099.74177 () probe ! kde ! org
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116764/#review52816
-----------------------------------------------------------
Looks good to me
- Kevin Krammer
On March 12, 2014, 2:25 p.m., Vishesh Handa wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/116764/
> -----------------------------------------------------------
>
> (Updated March 12, 2014, 2:25 p.m.)
>
>
> Review request for Baloo, Dan Vrátil and Kevin Krammer.
>
>
> Repository: baloo
>
>
> Description
> -------
>
> Use XDG_DATA_HOME instead of KDE HOME
>
> This is being done so that in the near future with KF5, the data
> directory is kept the same. This will allow both KF5 Baloo and Qt4 Baloo
> to easily co-exist and use the same database.
>
> This will mean that everyone's database will need to be reindexed, but
> since we haven't made a release so far. It shouldn't be a problem. Plus
> indexing is quite fast.
>
>
> Diffs
> -----
>
> src/file/cleaner/main.cpp 3000b6c
> src/file/extractor/app.cpp 77e5f5f
> src/file/lib/db.cpp 197e962
> src/file/main.cpp a62b4e9
> src/file/search/filesearchstore.cpp 472130c
> src/pim/agent/agent.cpp 7429c1f
> src/pim/lib/contactcompleter.cpp c01b0e9
> src/pim/lib/contactquery.cpp 77c2a6c
> src/pim/lib/emailquery.cpp b38045a
> src/pim/lib/notequery.cpp 7e0a24b
> src/pim/search/contact/contactsearchstore.cpp d4d010e
> src/pim/search/email/emailsearchstore.cpp 76bca53
> src/pim/search/note/notesearchstore.cpp e0af291
>
> Diff: https://git.reviewboard.kde.org/r/116764/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Vishesh Handa
>
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/116764/">https://git.reviewboard.kde.org/r/116764/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Looks good to me</pre> \
<br />
<p>- Kevin Krammer</p>
<br />
<p>On March 12th, 2014, 2:25 p.m. UTC, Vishesh Handa wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for Baloo, Dan Vrátil and Kevin Krammer.</div>
<div>By Vishesh Handa.</div>
<p style="color: grey;"><i>Updated March 12, 2014, 2:25 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
baloo
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"> Use XDG_DATA_HOME instead of KDE HOME
This is being done so that in the near future with KF5, the data
directory is kept the same. This will allow both KF5 Baloo and Qt4 Baloo
to easily co-exist and use the same database.
This will mean that everyone's database will need to be reindexed, but
since we haven't made a release so far. It shouldn't be a problem. Plus
indexing is quite fast.
</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/file/cleaner/main.cpp <span style="color: grey">(3000b6c)</span></li>
<li>src/file/extractor/app.cpp <span style="color: grey">(77e5f5f)</span></li>
<li>src/file/lib/db.cpp <span style="color: grey">(197e962)</span></li>
<li>src/file/main.cpp <span style="color: grey">(a62b4e9)</span></li>
<li>src/file/search/filesearchstore.cpp <span style="color: \
grey">(472130c)</span></li>
<li>src/pim/agent/agent.cpp <span style="color: grey">(7429c1f)</span></li>
<li>src/pim/lib/contactcompleter.cpp <span style="color: grey">(c01b0e9)</span></li>
<li>src/pim/lib/contactquery.cpp <span style="color: grey">(77c2a6c)</span></li>
<li>src/pim/lib/emailquery.cpp <span style="color: grey">(b38045a)</span></li>
<li>src/pim/lib/notequery.cpp <span style="color: grey">(7e0a24b)</span></li>
<li>src/pim/search/contact/contactsearchstore.cpp <span style="color: \
grey">(d4d010e)</span></li>
<li>src/pim/search/email/emailsearchstore.cpp <span style="color: \
grey">(76bca53)</span></li>
<li>src/pim/search/note/notesearchstore.cpp <span style="color: \
grey">(e0af291)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/116764/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
>> Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to unsubscribe <<
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic