'Re: Review Request 116701: file: Make g_detector a K_GLOBAL_STATIC.'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-devel
Subject:    Re: Review Request 116701: file: Make g_detector a K_GLOBAL_STATIC.
From:       "Vishesh Handa" <me () vhanda ! in>
Date:       2014-03-11 22:22:37
Message-ID: 20140311222237.3296.2739 () probe ! kde ! org
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116701/#review52693
-----------------------------------------------------------

Ship it!

Thanks!

- Vishesh Handa

On March 10, 2014, 11:12 p.m., Raphael Kubo da Costa wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/116701/
> -----------------------------------------------------------
> 
> (Updated March 10, 2014, 11:12 p.m.)
> 
> 
> Review request for Baloo and Vishesh Handa.
> 
> 
> Repository: baloo
> 
> 
> Description
> -------
> 
> XattrDetector is a QObject-derived class, so keeping a global static object
> around is dangerous.
> 
> 
> Diffs
> -----
> 
>   src/file/lib/filecustommetadata.cpp e63f34662400c5f1e36a458af10d6c6d7b0f65a2 
> 
> Diff: https://git.reviewboard.kde.org/r/116701/diff/
> 
> 
> Testing
> -------
> 
> Nothing exploded, everything built and all tests keep passing.
> 
> 
> Thanks,
> 
> Raphael Kubo da Costa
> 
>

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/116701/">https://git.reviewboard.kde.org/r/116701/</a>
  </td>
    </tr>
   </table>
   <br />

 <p>Ship it!</p>

 <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Thanks!</pre>  <br />

<p>- Vishesh Handa</p>

<br />
<p>On March 10th, 2014, 11:12 p.m. UTC, Raphael Kubo da Costa wrote:</p>

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for Baloo and Vishesh Handa.</div>
<div>By Raphael Kubo da Costa.</div>

<p style="color: grey;"><i>Updated March 10, 2014, 11:12 p.m.</i></p>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
baloo
</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">XattrDetector is a QObject-derived class, so keeping a global static \
object around is dangerous.</pre>
  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Nothing exploded, everything built and all tests keep passing.</pre>  \
</td>  </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>src/file/lib/filecustommetadata.cpp <span style="color: \
grey">(e63f34662400c5f1e36a458af10d6c6d7b0f65a2)</span></li>

</ul>

<p><a href="https://git.reviewboard.kde.org/r/116701/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

>> Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to unsubscribe <<

[prev in list] [next in list] [prev in thread] [next in thread] 