[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-devel
Subject:    Re: Patch acceptance runs too long.
From:       David Edmundson <david () davidedmundson ! co ! uk>
Date:       2013-03-17 14:17:09
Message-ID: CAGeFrHBT9SyM_Sf+tFtOMFPHM14vEnvuX9wGSaQ=Nm-kOH46Qg () mail ! gmail ! com
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]


On Sun, Mar 17, 2013 at 12:05 PM, Stefan Eggers <coloncolonone@gmail.com>wrote:

> In addition to what others wrote:
>
> Once it got accepted someone has to commit it. This is not automatic as I
> found out with my first patch for KDE Telepathy. If you don't have commit
> rights yourself you can state so in a comment in the review so that others
> know about this.
>
>
As reviewers always ask if the submitter has commit access when clicking
"ship it!", especially if it's a name that's unfamiliar. Given my team is
mentioned above, I hope we did that :)

I suggest using reviewboard-am for applying patches and committing.


> On Mon, Mar 11, 2013 at 10:12 PM, Alexey Shmalko <rasen.dubi@gmail.com>wrote:
>>
>> It seems that acceptance process is running for too long, because I've
>> sent patch six months ago. And it isn't accepted yet.
>>
>> What should I do?
>>
>
>
> >> Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to
> unsubscribe <<
>
>

[Attachment #5 (text/html)]

<br><br><div class="gmail_quote">On Sun, Mar 17, 2013 at 12:05 PM, Stefan Eggers \
<span dir="ltr">&lt;<a href="mailto:coloncolonone@gmail.com" \
target="_blank">coloncolonone@gmail.com</a>&gt;</span> wrote:<br><blockquote \
class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc \
solid;padding-left:1ex"> In addition to what others wrote:<div><br></div><div>Once it \
got accepted someone has to commit it. This is not automatic as I found out with my \
first patch for KDE Telepathy. If you don&#39;t have commit rights yourself you can \
state so in a comment in the review so that others know about this.<div class="im"> \
<div>

<br></div></div></div></blockquote><div><br></div><div>As reviewers always ask if the \
submitter has commit access when clicking &quot;ship it!&quot;, especially if \
it&#39;s a name that&#39;s unfamiliar. Given my team is mentioned above, I hope we \
did that :)</div> <div><br></div><div>I suggest using reviewboard-am for applying \
patches and committing.</div><div> </div><blockquote class="gmail_quote" \
style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div><div \
class="im"> <div><div class="gmail_quote">On Mon, Mar 11, 2013 at 10:12 PM, Alexey \
Shmalko <span dir="ltr">&lt;<a href="mailto:rasen.dubi@gmail.com" \
target="_blank">rasen.dubi@gmail.com</a>&gt;</span> wrote:<blockquote \
class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc \
solid;padding-left:1ex">


<div dir="ltr"><div>It seems that acceptance process is running for too long, because \
I&#39;ve sent patch six months ago. And it isn&#39;t accepted yet.</div> \
<div><br></div><div>What should I do? </div></div></blockquote></div> \
</div></div></div> <br><br>
&gt;&gt; Visit <a href="http://mail.kde.org/mailman/listinfo/kde-devel#unsub" \
target="_blank">http://mail.kde.org/mailman/listinfo/kde-devel#unsub</a> to \
unsubscribe &lt;&lt;<br> <br></blockquote></div><br>



>> Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to unsubscribe <<


[prev in list] [next in list] [prev in thread] [next in thread]