--===============7811402493399382434==
Content-Type: multipart/alternative; boundary=f46d044306aa1f7f2004d81f87d1

--f46d044306aa1f7f2004d81f87d1
Content-Type: text/plain; charset=ISO-8859-1

On Sun, Mar 17, 2013 at 12:05 PM, Stefan Eggers <coloncolonone@gmail.com>wrote:

> In addition to what others wrote:
>
> Once it got accepted someone has to commit it. This is not automatic as I
> found out with my first patch for KDE Telepathy. If you don't have commit
> rights yourself you can state so in a comment in the review so that others
> know about this.
>
>
As reviewers always ask if the submitter has commit access when clicking
"ship it!", especially if it's a name that's unfamiliar. Given my team is
mentioned above, I hope we did that :)

I suggest using reviewboard-am for applying patches and committing.


> On Mon, Mar 11, 2013 at 10:12 PM, Alexey Shmalko <rasen.dubi@gmail.com>wrote:
>>
>> It seems that acceptance process is running for too long, because I've
>> sent patch six months ago. And it isn't accepted yet.
>>
>> What should I do?
>>
>
>
> >> Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to
> unsubscribe <<
>
>

--f46d044306aa1f7f2004d81f87d1
Content-Type: text/html; charset=ISO-8859-1
Content-Transfer-Encoding: quoted-printable

<br><br><div class=3D"gmail_quote">On Sun, Mar 17, 2013 at 12:05 PM, Stefan=
 Eggers <span dir=3D"ltr">&lt;<a href=3D"mailto:coloncolonone@gmail.com" ta=
rget=3D"_blank">coloncolonone@gmail.com</a>&gt;</span> wrote:<br><blockquot=
e class=3D"gmail_quote" style=3D"margin:0 0 0 .8ex;border-left:1px #ccc sol=
id;padding-left:1ex">
In addition to what others wrote:<div><br></div><div>Once it got accepted s=
omeone has to commit it. This is not automatic as I found out with my first=
 patch for KDE Telepathy. If you don&#39;t have commit rights yourself you =
can state so in a comment in the review so that others know about this.<div=
 class=3D"im">
<div>

<br></div></div></div></blockquote><div><br></div><div>As reviewers always =
ask if the submitter has commit access when clicking &quot;ship it!&quot;, =
especially if it&#39;s a name that&#39;s unfamiliar. Given my team is menti=
oned above, I hope we did that :)</div>
<div><br></div><div>I suggest using reviewboard-am for applying patches and=
 committing.</div><div>=A0</div><blockquote class=3D"gmail_quote" style=3D"=
margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div><div cl=
ass=3D"im">
<div><div class=3D"gmail_quote">On Mon, Mar 11, 2013 at 10:12 PM, Alexey Sh=
malko <span dir=3D"ltr">&lt;<a href=3D"mailto:rasen.dubi@gmail.com" target=
=3D"_blank">rasen.dubi@gmail.com</a>&gt;</span> wrote:<blockquote class=3D"=
gmail_quote" style=3D"margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-=
left:1ex">


<div dir=3D"ltr"><div>It seems that acceptance process is running for too l=
ong, because I&#39;ve sent patch six months ago. And it isn&#39;t accepted =
yet.</div>
<div><br></div><div>What should I do?=A0</div></div></blockquote></div>
</div></div></div>
<br><br>
&gt;&gt; Visit <a href=3D"http://mail.kde.org/mailman/listinfo/kde-devel#un=
sub" target=3D"_blank">http://mail.kde.org/mailman/listinfo/kde-devel#unsub=
</a> to unsubscribe &lt;&lt;<br>
<br></blockquote></div><br>

--f46d044306aa1f7f2004d81f87d1--

--===============7811402493399382434==
Content-Type: text/plain; charset="us-ascii"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Content-Disposition: inline


>> Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to unsubscribe <<

--===============7811402493399382434==--