[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-devel
Subject: Re: Async action with helper in KAuth
From: Dario Freddi <drf54321 () gmail ! com>
Date: 2012-11-15 15:08:35
Message-ID: CAFFVnfPZ0P2LyGKVZRYvW9Xi9oQJ5sh-prVKq6RzSTsc9m-1qA () mail ! gmail ! com
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
2012/11/15 Yichao Yu <yyc1992@gmail.com>
> Filed a bug here[1], hopefully this will help you tracking the bug and
> to cherrypick/fix it in other branches.
>
> [1] https://bugs.kde.org/show_bug.cgi?id=310149
Thanks!
>
>
> On Thu, Nov 15, 2012 at 8:45 AM, Dario Freddi <drf54321@gmail.com> wrote:
> > Hello Yichao,
> >
> > 2012/11/12 Yichao Yu <yyc1992@gmail.com>
> >>
> >> I checkout out the code for KAuth and found out the following lines
> >> in` ActionReply Action::execute(const QString &helperID) const`
> >>
> >> if (d->async) {
> >> if (hasHelper()) {
> >> // It makes no sense
> >> return ActionReply::InvalidActionReply;
> >> }
> >>
> >> which gives the right error code and can explain why only the async
> >> action fails. The comment says "makes no sense", but doesn't say
> >> why.... can anyone explain the reason??
> >
> >
> > Looks like there is a logical error in the code that I forgot to fix in
> the
> > 4.x branch. if (!hasHelper()) is the correct line, and if the action has
> no
> > helper it doesn't make sense to execute it asynchronously since there is
> > actually nothing to do, but only to authorize. Sorry about that, I will
> > provide a fix ASAP - my main focus lately has been the framework branch,
> > where most of the logic actually changed.
> >
> >>
> >> And I cannot found the
> >> description for this anywhere in the tutorial (e.g. some backend may
> >> not support async action with helper at all.....), if it really
> >> doesn't make sense to do this (which I really doubt....) I guess it
> >> would be better to add it...
> >
> >
> > What you are doing is perfectly supported and the bug is in the library.
> >
> >>
> >>
> >> THX.
> >>
> >>
> >> [1] http://forum.kde.org/viewtopic.php?f=43&t=94801
> >>
> >> >> Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to
> >> >> unsubscribe <<
> >
> >
> >
> >
> >>> Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to
> unsubscribe
> >>> <<
> >
>
[Attachment #5 (text/html)]
<div class="gmail_extra"><br><div class="gmail_quote">2012/11/15 Yichao Yu <span \
dir="ltr"><<a href="mailto:yyc1992@gmail.com" \
target="_blank">yyc1992@gmail.com</a>></span><br><blockquote class="gmail_quote" \
style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"> Filed a bug \
here[1], hopefully this will help you tracking the bug and<br> to cherrypick/fix it \
in other branches.<br> <br>
[1] <a href="https://bugs.kde.org/show_bug.cgi?id=310149" \
target="_blank">https://bugs.kde.org/show_bug.cgi?id=310149</a></blockquote><div><br></div><div>Thanks!</div><div> \
</div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc \
solid;padding-left:1ex"> <br>
<div class="im HOEnZb"><br>
On Thu, Nov 15, 2012 at 8:45 AM, Dario Freddi <<a \
href="mailto:drf54321@gmail.com">drf54321@gmail.com</a>> wrote:<br> </div><div \
class="HOEnZb"><div class="h5">> Hello Yichao,<br> ><br>
> 2012/11/12 Yichao Yu <<a \
href="mailto:yyc1992@gmail.com">yyc1992@gmail.com</a>><br> >><br>
>> I checkout out the code for KAuth and found out the following lines<br>
>> in` ActionReply Action::execute(const QString &helperID) const`<br>
>><br>
>> if (d->async) {<br>
>> if (hasHelper()) {<br>
>> // It makes no sense<br>
>> return ActionReply::InvalidActionReply;<br>
>> }<br>
>><br>
>> which gives the right error code and can explain why only the async<br>
>> action fails. The comment says "makes no sense", but doesn't \
say<br> >> why.... can anyone explain the reason??<br>
><br>
><br>
> Looks like there is a logical error in the code that I forgot to fix in the<br>
> 4.x branch. if (!hasHelper()) is the correct line, and if the action has no<br>
> helper it doesn't make sense to execute it asynchronously since there is<br>
> actually nothing to do, but only to authorize. Sorry about that, I will<br>
> provide a fix ASAP - my main focus lately has been the framework branch,<br>
> where most of the logic actually changed.<br>
><br>
>><br>
>> And I cannot found the<br>
>> description for this anywhere in the tutorial (e.g. some backend may<br>
>> not support async action with helper at all.....), if it really<br>
>> doesn't make sense to do this (which I really doubt....) I guess it<br>
>> would be better to add it...<br>
><br>
><br>
> What you are doing is perfectly supported and the bug is in the library.<br>
><br>
>><br>
>><br>
>> THX.<br>
>><br>
>><br>
>> [1] <a href="http://forum.kde.org/viewtopic.php?f=43&t=94801" \
target="_blank">http://forum.kde.org/viewtopic.php?f=43&t=94801</a><br> \
>><br> >> >> Visit <a \
href="http://mail.kde.org/mailman/listinfo/kde-devel#unsub" \
target="_blank">http://mail.kde.org/mailman/listinfo/kde-devel#unsub</a> to<br> \
>> >> unsubscribe <<<br> ><br>
><br>
><br>
><br>
>>> Visit <a href="http://mail.kde.org/mailman/listinfo/kde-devel#unsub" \
target="_blank">http://mail.kde.org/mailman/listinfo/kde-devel#unsub</a> to \
unsubscribe<br> >>> <<<br>
><br>
</div></div></blockquote></div><br></div>
>> Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to unsubscribe <<
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic