[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-devel
Subject:    Re: Async action with helper in KAuth
From:       Dario Freddi <drf54321 () gmail ! com>
Date:       2012-11-15 13:45:20
Message-ID: CAFFVnfMq0DPaP46PR6wBynL0f_3AzWtMY_zKodFVgD2dPuaVGQ () mail ! gmail ! com
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]


Hello Yichao,

2012/11/12 Yichao Yu <yyc1992@gmail.com>
>
> I checkout out the code for KAuth and found out the following lines
> in` ActionReply Action::execute(const QString &helperID) const`
>
>     if (d->async) {
>         if (hasHelper()) {
>             // It makes no sense
>             return ActionReply::InvalidActionReply;
>         }
>
> which gives the right error code and can explain why only the async
> action fails. The comment says "makes no sense", but doesn't say
> why.... can anyone explain the reason??


Looks like there is a logical error in the code that I forgot to fix in the
4.x branch. if (!hasHelper()) is the correct line, and if the action has no
helper it doesn't make sense to execute it asynchronously since there is
actually nothing to do, but only to authorize. Sorry about that, I will
provide a fix ASAP - my main focus lately has been the framework branch,
where most of the logic actually changed.


> And I cannot found the
> description for this anywhere in the tutorial (e.g. some backend may
> not support async action with helper at all.....), if it really
> doesn't make sense to do this (which I really doubt....) I guess it
> would be better to add it...
>

What you are doing is perfectly supported and the bug is in the library.


>
> THX.
>
>
> [1] http://forum.kde.org/viewtopic.php?f=43&t=94801
>
> >> Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to
> unsubscribe <<
>

[Attachment #5 (text/html)]

Hello Yichao,<div class="gmail_extra"><br><div class="gmail_quote">2012/11/12 Yichao \
Yu <span dir="ltr">&lt;<a href="mailto:yyc1992@gmail.com" \
target="_blank">yyc1992@gmail.com</a>&gt;</span><blockquote class="gmail_quote" \
style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">

I checkout out the code for KAuth and found out the following lines<br>
in` ActionReply Action::execute(const QString &amp;helperID) const`<br>
<br>
    if (d-&gt;async) {<br>
        if (hasHelper()) {<br>
            // It makes no sense<br>
            return ActionReply::InvalidActionReply;<br>
        }<br>
<br>
which gives the right error code and can explain why only the async<br>
action fails. The comment says &quot;makes no sense&quot;, but doesn&#39;t say<br>
why.... can anyone explain the reason??</blockquote><div><br></div><div>Looks like \
there is a logical error in the code that I forgot to fix in the 4.x branch. if \
(!hasHelper()) is the correct line, and if the action has no helper it doesn&#39;t \
make sense to execute it asynchronously since there is actually nothing to do, but \
only to authorize. Sorry about that, I will provide a fix ASAP - my main focus lately \
has been the framework branch, where most of the logic actually changed.</div> <div> \
</div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc \
solid;padding-left:1ex"> And I cannot found the<br> description for this anywhere in \
the tutorial (e.g. some backend may<br> not support async action with helper at \
all.....), if it really<br> doesn&#39;t make sense to do this (which I really \
doubt....) I guess it<br> would be better to add \
it...<br></blockquote><div><br></div><div>What you are doing is perfectly supported \
and the bug is in the library.</div><div> </div><blockquote class="gmail_quote" \
style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">

<br>
THX.<br>
<br>
<br>
[1] <a href="http://forum.kde.org/viewtopic.php?f=43&amp;t=94801" \
target="_blank">http://forum.kde.org/viewtopic.php?f=43&amp;t=94801</a><br> <br>
&gt;&gt; Visit <a href="http://mail.kde.org/mailman/listinfo/kde-devel#unsub" \
target="_blank">http://mail.kde.org/mailman/listinfo/kde-devel#unsub</a> to \
unsubscribe &lt;&lt;<br> </blockquote></div><br></div>



>> Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to unsubscribe <<


[prev in list] [next in list] [prev in thread] [next in thread]