From kde-devel  Thu Nov 15 13:45:20 2012
From: Dario Freddi <drf54321 () gmail ! com>
Date: Thu, 15 Nov 2012 13:45:20 +0000
To: kde-devel
Subject: Re: Async action with helper in KAuth
Message-Id: <CAFFVnfMq0DPaP46PR6wBynL0f_3AzWtMY_zKodFVgD2dPuaVGQ () mail ! gmail ! com>
X-MARC-Message: https://marc.info/?l=kde-devel&m=135298715403036
MIME-Version: 1
Content-Type: multipart/mixed; boundary="--===============6067423837052419769=="

--===============6067423837052419769==
Content-Type: multipart/alternative; boundary=f46d042f9e0aba835904ce88dcf9

--f46d042f9e0aba835904ce88dcf9
Content-Type: text/plain; charset=ISO-8859-1

Hello Yichao,

2012/11/12 Yichao Yu <yyc1992@gmail.com>
>
> I checkout out the code for KAuth and found out the following lines
> in` ActionReply Action::execute(const QString &helperID) const`
>
>     if (d->async) {
>         if (hasHelper()) {
>             // It makes no sense
>             return ActionReply::InvalidActionReply;
>         }
>
> which gives the right error code and can explain why only the async
> action fails. The comment says "makes no sense", but doesn't say
> why.... can anyone explain the reason??


Looks like there is a logical error in the code that I forgot to fix in the
4.x branch. if (!hasHelper()) is the correct line, and if the action has no
helper it doesn't make sense to execute it asynchronously since there is
actually nothing to do, but only to authorize. Sorry about that, I will
provide a fix ASAP - my main focus lately has been the framework branch,
where most of the logic actually changed.


> And I cannot found the
> description for this anywhere in the tutorial (e.g. some backend may
> not support async action with helper at all.....), if it really
> doesn't make sense to do this (which I really doubt....) I guess it
> would be better to add it...
>

What you are doing is perfectly supported and the bug is in the library.


>
> THX.
>
>
> [1] http://forum.kde.org/viewtopic.php?f=43&t=94801
>
> >> Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to
> unsubscribe <<
>

--f46d042f9e0aba835904ce88dcf9
Content-Type: text/html; charset=ISO-8859-1
Content-Transfer-Encoding: quoted-printable

Hello Yichao,<div class=3D"gmail_extra"><br><div class=3D"gmail_quote">2012=
/11/12 Yichao Yu <span dir=3D"ltr">&lt;<a href=3D"mailto:yyc1992@gmail.com"=
 target=3D"_blank">yyc1992@gmail.com</a>&gt;</span><blockquote class=3D"gma=
il_quote" style=3D"margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-lef=
t:1ex">

I checkout out the code for KAuth and found out the following lines<br>
in` ActionReply Action::execute(const QString &amp;helperID) const`<br>
<br>
=A0 =A0 if (d-&gt;async) {<br>
=A0 =A0 =A0 =A0 if (hasHelper()) {<br>
=A0 =A0 =A0 =A0 =A0 =A0 // It makes no sense<br>
=A0 =A0 =A0 =A0 =A0 =A0 return ActionReply::InvalidActionReply;<br>
=A0 =A0 =A0 =A0 }<br>
<br>
which gives the right error code and can explain why only the async<br>
action fails. The comment says &quot;makes no sense&quot;, but doesn&#39;t =
say<br>
why.... can anyone explain the reason??</blockquote><div><br></div><div>Loo=
ks like there is a logical error in the code that I forgot to fix in the 4.=
x branch. if (!hasHelper()) is the correct line, and if the action has no h=
elper it doesn&#39;t make sense to execute it asynchronously since there is=
 actually nothing to do, but only to authorize. Sorry about that, I will pr=
ovide a fix ASAP - my main focus lately has been the framework branch, wher=
e most of the logic actually changed.</div>
<div>=A0</div><blockquote class=3D"gmail_quote" style=3D"margin:0 0 0 .8ex;=
border-left:1px #ccc solid;padding-left:1ex"> And I cannot found the<br>
description for this anywhere in the tutorial (e.g. some backend may<br>
not support async action with helper at all.....), if it really<br>
doesn&#39;t make sense to do this (which I really doubt....) I guess it<br>
would be better to add it...<br></blockquote><div><br></div><div>What you a=
re doing is perfectly supported and the bug is in the library.</div><div>=
=A0</div><blockquote class=3D"gmail_quote" style=3D"margin:0 0 0 .8ex;borde=
r-left:1px #ccc solid;padding-left:1ex">

<br>
THX.<br>
<br>
<br>
[1] <a href=3D"http://forum.kde.org/viewtopic.php?f=3D43&amp;t=3D94801" tar=
get=3D"_blank">http://forum.kde.org/viewtopic.php?f=3D43&amp;t=3D94801</a><=
br>
<br>
&gt;&gt; Visit <a href=3D"http://mail.kde.org/mailman/listinfo/kde-devel#un=
sub" target=3D"_blank">http://mail.kde.org/mailman/listinfo/kde-devel#unsub=
</a> to unsubscribe &lt;&lt;<br>
</blockquote></div><br></div>

--f46d042f9e0aba835904ce88dcf9--

--===============6067423837052419769==
Content-Type: text/plain; charset="us-ascii"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Content-Disposition: inline


>> Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to unsubscribe <<

--===============6067423837052419769==--